Handle authentication failures in the v2 app by restarting the app

remoting/webapp/crd/js/crd_event_handlers.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 remoting.initElementEventHandlers = function() {
@@ skipping 20 matching lines @@
   };
   /** @param {Event} event The event. */
   var sendAccessCode = function(event) {
     remoting.connectIT2Me();
     event.preventDefault();
   };
   var reconnect = function() {
     remoting.setMode(remoting.AppMode.CLIENT_CONNECTING);
     remoting.app.getSessionConnector().reconnect();
   };
-  var doAuthRedirect = function() {
-    if (!base.isAppsV2()) {
-      remoting.oauth2.doAuthRedirect(function() {
-        window.location.reload();
-      });
-    }
-  };
-  var fixAuthError = function() {
-    if (base.isAppsV2()) {
-      var onRefresh = function() {
-        remoting.hostList.display();
-      };
-      var refreshHostList = function() {
-        goHome();
-        remoting.hostList.refresh(onRefresh);
-      };
-      remoting.identity.removeCachedAuthToken(refreshHostList);
-    } else {
-      doAuthRedirect();
-    }
+  var handleAuthFailure = function() {
+    remoting.identity.handleAuthFailureAndRelaunch();
   };
   /** @param {Event} event The event. */
   var stopDaemon = function(event) {
     remoting.hostSetupDialog.showForStop();
     event.stopPropagation();
   };
   var cancelAccessCode = function() {
     remoting.setMode(remoting.AppMode.HOME);
     document.getElementById('access-code-entry').value = '';
   };
@@ skipping 27 matching lines @@
       { event: 'click', id: 'close-paired-client-manager-dialog', fn: goHome },
       { event: 'click', id: 'host-config-done-dismiss', fn: goHome },
       { event: 'click', id: 'host-config-error-dismiss', fn: goHome },
       { event: 'click', id: 'open-paired-client-manager-dialog',
         fn: remoting.setMode.bind(null,
                                   remoting.AppMode.HOME_MANAGE_PAIRINGS) },
       { event: 'click', id: 'stop-sharing-button', fn: remoting.cancelShare }
   ];
   /** @type {Array.<{event: string, id: string, fn: function(Event):void}>} */
   var auth_actions = [
-      { event: 'click', id: 'auth-button', fn: doAuthRedirect },
+      { event: 'click', id: 'auth-button', fn: handleAuthFailure },

[Jamie, 2015/01/23 23:33:26]

I'm not sure this will work. I think "auth-button" is also used to grant consent
for chrome.identity (which was fine with the old code, because it's conditional
on !appsv2). Now, first-time sign-in is likely to be broken because as well as
asking the user to authenticate, we'll relaunch the app.

[kelvinp, 2015/01/28 00:26:45]

Done.

       { event: 'click', id: 'cancel-connect-button', fn: goHome },
       { event: 'click', id: 'sign-out', fn:remoting.signOut },
       { event: 'click', id: 'token-refresh-error-ok', fn: goHome },
-      { event: 'click', id: 'token-refresh-error-sign-in', fn: fixAuthError }
+      { event: 'click', id: 'token-refresh-error-sign-in',
+        fn: handleAuthFailure }
   ];
   registerEventListeners(it2me_actions);
   registerEventListeners(me2me_actions);
   registerEventListeners(host_actions);
   registerEventListeners(auth_actions);
 }