Handle authentication failures in the v2 app by restarting the app

remoting/webapp/crd/js/app_launcher.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * AppLauncher is an interface that allows the client code to launch and close
  * the app without knowing the implementation difference between a v1 app and
  * a v2 app.
  *
  * To launch an app:
  *   var appLauncher = new remoting.V1AppLauncher();
  *   var appId = "";
  *   appLauncher.launch({arg1:'someValue'}).then(function(id){
  *    appId = id;
  *   });
  *
  * To close an app:
  *   appLauncher.close(appId);
  */
 
-'use strict';
-
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
+(function() {
+
+'use strict';
+
 /** @interface */
 remoting.AppLauncher = function() {};
 
 /**
  * @param {Object=} opt_launchArgs
  * @return {Promise} The promise will resolve when the app is launched.  It will
  * provide the caller with the appId (which is either the id of the hosting tab
  * or window). The caller can use the appId to close the app.
  */
 remoting.AppLauncher.prototype.launch = function(opt_launchArgs) { };
@@ skipping 47 matching lines @@
   });
 };
 
 
 /**
  * @constructor
  * @implements {remoting.AppLauncher}
  */
 remoting.V2AppLauncher = function() {};
 
+var APP_MAIN_URL = 'main.html';
+
 /**
- * @type {number}
- * @private
+ * @param {string} id
  */
-remoting.V2AppLauncher.nextWindowId_ = 0;
+remoting.V2AppLauncher.prototype.restart = function(id) {
+  base.debug.assert(base.isBackgroundPage(),
+                    'restart() can only be called from the background page');

[Jamie, 2015/01/23 23:33:26]

It would be better if this code file was simply not included in the main page.

[kelvinp, 2015/01/28 00:26:45]

Done.

+  this.close(id).then(function() {
+    return chrome.app.window.create(APP_MAIN_URL, {'id' : id, 'frame': 'none'});

[Jamie, 2015/01/23 23:33:26]

Please add a comment explaining why we're not re-using the launch method (I
think it's just because we want to reuse the window id, size etc).

[kelvinp, 2015/01/28 00:26:45]

Done.

+  });
+};
 
 remoting.V2AppLauncher.prototype.launch = function(opt_launchArgs) {
-  var url = base.urlJoin('main.html', opt_launchArgs);
+  var url = base.urlJoin(APP_MAIN_URL, opt_launchArgs);
 
   /**
    * @param {function(*=):void} resolve
    * @param {function(*=):void} reject
    */
   return new Promise(function(resolve, reject) {
     chrome.app.window.create(url, {
         'width': 800,
         'height': 600,
         'frame': 'none',
-        'id': String(remoting.V2AppLauncher.nextWindowId_++)
+        'id': String(getNextWindowId())
       },
       /** @param {AppWindow=} appWindow */
       function(appWindow) {
         if (!appWindow) {
           reject(new Error(chrome.runtime.lastError.message));
         } else {
           resolve(appWindow.id);
         }
       });
   });
 };
 
 remoting.V2AppLauncher.prototype.close = function(id) {
-  var appWindow = chrome.app.window.get(id);
-  if (!appWindow) {
-    return Promise.reject(new Error(chrome.runtime.lastError.message));
-  }
-  appWindow.close();
-  return Promise.resolve();
+  /**
+   * @param {function(*=):void} resolve
+   * @param {function(*=):void} reject
+   */
+  return new Promise(function(resolve, reject) {
+    var appWindow = chrome.app.window.get(id);
+    if (!appWindow) {
+      return Promise.reject(new Error(chrome.runtime.lastError.message));
+    }
+    appWindow.onClosed.addListener(resolve);
+    appWindow.close();
+  });
 };
+
+/**
+ * @return {number} the next available window id.
+ */
+function getNextWindowId() {
+  var appWindows = chrome.app.window.getAll();
+  var lastId = /** @type(number) */ (0);
+  appWindows.forEach(function(appWindow) {
+    base.debug.assert(Number.isInteger(appWindow.id),
+                      "Window Id should be an integer");
+    var id = parseInt(appWindow.id, 10);
+    if (lastId <= id) {
+      lastId = id;
+    }
+  });
+  return ++lastId;
+}
+
+})();