Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 8682023: ppapi/tests: Enable URLLoader test out-of-process and via NaCl. (Closed)

Created:
9 years, 1 month ago by polina
Modified:
9 years ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

ppapi/tests: Enable URLLoader test out-of-process and via NaCl. Depends on: http://codereview.chromium.org/8682022/ BUG=89961 TEST=out/Debug/ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112065

Patch Set 1 : '' #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -50 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 1 chunk +2 lines, -12 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 1 chunk +1 line, -5 lines 0 comments Download
M ppapi/tests/test_url_loader.cc View 1 9 chunks +78 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
polina
Everything is passing locally, but I am still confirming out if the tests pass reliably ...
9 years ago (2011-11-29 09:08:13 UTC) #1
bbudge
LGTM w/nit. http://codereview.chromium.org/8682023/diff/3001/ppapi/tests/test_url_loader.cc File ppapi/tests/test_url_loader.cc (right): http://codereview.chromium.org/8682023/diff/3001/ppapi/tests/test_url_loader.cc#newcode466 ppapi/tests/test_url_loader.cc:466: // FileIO is not yet support by ...
9 years ago (2011-11-29 18:04:51 UTC) #2
dmichael (off chromium)
http://codereview.chromium.org/8682023/diff/3001/ppapi/tests/test_url_loader.cc File ppapi/tests/test_url_loader.cc (right): http://codereview.chromium.org/8682023/diff/3001/ppapi/tests/test_url_loader.cc#newcode110 ppapi/tests/test_url_loader.cc:110: if (!testing_interface_->IsOutOfProcess()) { Why not instead use the new ...
9 years ago (2011-11-29 18:11:12 UTC) #3
polina
http://codereview.chromium.org/8682023/diff/3001/ppapi/tests/test_url_loader.cc File ppapi/tests/test_url_loader.cc (right): http://codereview.chromium.org/8682023/diff/3001/ppapi/tests/test_url_loader.cc#newcode110 ppapi/tests/test_url_loader.cc:110: if (!testing_interface_->IsOutOfProcess()) { On 2011/11/29 18:11:13, dmichael wrote: > ...
9 years ago (2011-11-29 20:36:37 UTC) #4
dmichael (off chromium)
lgtm
9 years ago (2011-11-29 20:40:50 UTC) #5
polina
http://codereview.chromium.org/8682023/diff/3001/ppapi/tests/test_url_loader.cc File ppapi/tests/test_url_loader.cc (right): http://codereview.chromium.org/8682023/diff/3001/ppapi/tests/test_url_loader.cc#newcode466 ppapi/tests/test_url_loader.cc:466: // FileIO is not yet support by ppapi/proxy. On ...
9 years ago (2011-11-29 23:16:22 UTC) #6
polina
9 years ago (2011-11-29 23:29:25 UTC) #7
On 2011/11/29 23:16:22, polina wrote:
>
http://codereview.chromium.org/8682023/diff/3001/ppapi/tests/test_url_loader.cc
> File ppapi/tests/test_url_loader.cc (right):
> 
>
http://codereview.chromium.org/8682023/diff/3001/ppapi/tests/test_url_loader....
> ppapi/tests/test_url_loader.cc:466: // FileIO is not yet support by
ppapi/proxy.
> On 2011/11/29 18:04:51, bbudge1 wrote:
> > support->supported
> 
> Done.

Committed revision 112065.

Powered by Google App Engine
This is Rietveld 408576698