Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 868193002: Add GN files for bspatch. (Closed)

Created:
5 years, 11 months ago by Slava Chigrin
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GN files for bspatch. Committed: https://crrev.com/1279e919c020f60c785a0c6b0261ba339b72dd57 Cr-Commit-Position: refs/heads/master@{#313023}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update copyright. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
A third_party/bspatch/BUILD.gn View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Slava Chigrin
https://codereview.chromium.org/868193002/diff/1/third_party/bspatch/BUILD.gn File third_party/bspatch/BUILD.gn (right): https://codereview.chromium.org/868193002/diff/1/third_party/bspatch/BUILD.gn#newcode5 third_party/bspatch/BUILD.gn:5: source_set("bspatch") { Users of this target use absolute include ...
5 years, 11 months ago (2015-01-23 20:35:30 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/868193002/diff/1/third_party/bspatch/BUILD.gn File third_party/bspatch/BUILD.gn (right): https://codereview.chromium.org/868193002/diff/1/third_party/bspatch/BUILD.gn#newcode1 third_party/bspatch/BUILD.gn:1: # Copyright (c) 2015 The Chromium Authors. All ...
5 years, 11 months ago (2015-01-23 23:59:47 UTC) #3
Slava Chigrin
Done, thank you for review! https://codereview.chromium.org/868193002/diff/1/third_party/bspatch/BUILD.gn File third_party/bspatch/BUILD.gn (right): https://codereview.chromium.org/868193002/diff/1/third_party/bspatch/BUILD.gn#newcode1 third_party/bspatch/BUILD.gn:1: # Copyright (c) 2015 ...
5 years, 11 months ago (2015-01-24 16:20:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868193002/20001
5 years, 11 months ago (2015-01-24 16:21:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-24 17:10:33 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 17:11:13 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1279e919c020f60c785a0c6b0261ba339b72dd57
Cr-Commit-Position: refs/heads/master@{#313023}

Powered by Google App Engine
This is Rietveld 408576698