components/browser_watcher/watcher_metrics_provider_win.h - Issue 868163002: Only report exit funnels for canary and dev channels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_watcher/watcher_metrics_provider_win.h

Issue 868163002: Only report exit funnels for canary and dev channels. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Alexei's comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | components/browser_watcher/watcher_metrics_provider_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/browser_watcher/watcher_metrics_provider_win.h

diff --git a/components/browser_watcher/watcher_metrics_provider_win.h b/components/browser_watcher/watcher_metrics_provider_win.h

index d2a47545a5677375d5278de2897e6b97981de1a2..0004be3b7604102d0ae058ca8394de6ca5e69a95 100644

--- a/components/browser_watcher/watcher_metrics_provider_win.h

+++ b/components/browser_watcher/watcher_metrics_provider_win.h

@@ -27,7 +27,10 @@ class WatcherMetricsProviderWin : public metrics::MetricsProvider {

static const char kBrowserExitCodeHistogramName[];

static const char kExitFunnelHistogramPrefix[];

- explicit WatcherMetricsProviderWin(const base::char16* registry_path);

+ // Initializes the reporter. If |report_exit_funnels| is false, the provider

+ // will clear the registry data, but not report it.

+ WatcherMetricsProviderWin(const base::char16* registry_path,

+ bool report_exit_funnels);

~WatcherMetricsProviderWin();

// metrics::MetricsProvider implementation.

@@ -36,6 +39,7 @@ class WatcherMetricsProviderWin : public metrics::MetricsProvider {

private:

base::string16 registry_path_;

+ bool report_exit_funnels_;

DISALLOW_COPY_AND_ASSIGN(WatcherMetricsProviderWin);

};