Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2928)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 868163002: Only report exit funnels for canary and dev channels. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_metrics_service_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc
index 7bfc7393d3d7e20256b43830f09acbd1811c238b..5d3094134cc2106451f365ecdd04e3c89ecf2da7 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc
@@ -296,10 +296,19 @@ void ChromeMetricsServiceClient::Initialize() {
metrics_service_->RegisterMetricsProvider(
scoped_ptr<metrics::MetricsProvider>(google_update_metrics_provider_));
+ // Report exit funnels for canary and dev only.
+ bool report_exit_funnels = false;
+ switch (chrome::VersionInfo::GetChannel()) {
+ case chrome::VersionInfo::CHANNEL_CANARY:
+ case chrome::VersionInfo::CHANNEL_DEV:
+ report_exit_funnels = true;
Alexei Svitkine (slow) 2015/01/23 18:45:22 Why can't this code be part of WatcherMetricsProvi
Sigurður Ásgeirsson 2015/01/23 18:48:43 The provider is a component - I didn't think it's
Alexei Svitkine (slow) 2015/01/23 18:50:53 Ah, you're absolutely right!
+ break;
+ }
+
metrics_service_->RegisterMetricsProvider(
scoped_ptr<metrics::MetricsProvider>(
new browser_watcher::WatcherMetricsProviderWin(
- chrome::kBrowserExitCodesRegistryPath)));
+ chrome::kBrowserExitCodesRegistryPath, report_exit_funnels)));
#endif // defined(OS_WIN)
#if defined(ENABLE_PLUGINS)

Powered by Google App Engine
This is Rietveld 408576698