Only report exit funnels for canary and dev channels.

components/browser_watcher/watcher_metrics_provider_win_unittest.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/browser_watcher/watcher_metrics_provider_win.h"
 
 #include <cstdlib>
 
 #include "base/process/process_handle.h"
 #include "base/strings/string16.h"
@@ skipping 63 matching lines @@
 }  // namespace
 
 TEST_F(WatcherMetricsProviderWinTest, RecordsStabilityHistogram) {
   // Record multiple success exits.
   for (size_t i = 0; i < 11; ++i)
     AddProcessExitCode(false, 0);
 
   // Record a single failure.
   AddProcessExitCode(false, 100);
 
-  WatcherMetricsProviderWin provider(kRegistryPath);
+  WatcherMetricsProviderWin provider(kRegistryPath, true);
 
   provider.ProvideStabilityMetrics(NULL);
   histogram_tester_.ExpectBucketCount(
         WatcherMetricsProviderWin::kBrowserExitCodeHistogramName, 0, 11);
   histogram_tester_.ExpectBucketCount(
         WatcherMetricsProviderWin::kBrowserExitCodeHistogramName, 100, 1);
   histogram_tester_.ExpectTotalCount(
         WatcherMetricsProviderWin::kBrowserExitCodeHistogramName, 12);
 
   // Verify that the reported values are gone.
   EXPECT_EQ(ExitCodeRegistryPathValueCount(), 0);
 }
 
 TEST_F(WatcherMetricsProviderWinTest, DoesNotReportOwnProcessId) {
   // Record multiple success exits.
   for (size_t i = 0; i < 11; ++i)
     AddProcessExitCode(i, 0);
 
   // Record own process as STILL_ACTIVE.
   AddProcessExitCode(true, STILL_ACTIVE);
 
-  WatcherMetricsProviderWin provider(kRegistryPath);
+  WatcherMetricsProviderWin provider(kRegistryPath, true);
 
   provider.ProvideStabilityMetrics(NULL);
   histogram_tester_.ExpectUniqueSample(
         WatcherMetricsProviderWin::kBrowserExitCodeHistogramName, 0, 11);
 
   // Verify that the reported values are gone.
   EXPECT_EQ(ExitCodeRegistryPathValueCount(), 1);
 }
 
 TEST_F(WatcherMetricsProviderWinTest, RecordsOrderedExitFunnelEvents) {
   // Record an exit funnel with a given set of timings and check that the
   // ordering is correct on the reported histograms.
   // Note the recorded times are in microseconds, but the reporting is in
   // milliseconds, hence the times 1000.
   AddExitFunnelEvent(100, L"One", 1000 * 1000);
   AddExitFunnelEvent(100, L"Two", 1010 * 1000);
   AddExitFunnelEvent(100, L"Three", 990 * 1000);
 
-  WatcherMetricsProviderWin provider(kRegistryPath);
+  WatcherMetricsProviderWin provider(kRegistryPath, true);
 
   provider.ProvideStabilityMetrics(NULL);
   histogram_tester_.ExpectUniqueSample("Stability.ExitFunnel.Three", 0, 1);
   histogram_tester_.ExpectUniqueSample("Stability.ExitFunnel.One", 10, 1);
   histogram_tester_.ExpectUniqueSample("Stability.ExitFunnel.Two", 20, 1);
 
   // Make sure the subkey is deleted on reporting.
   base::win::RegistryKeyIterator it(HKEY_CURRENT_USER, kRegistryPath);
   ASSERT_EQ(it.SubkeyCount(), 0);
 }
@@ skipping 10 matching lines @@
   // which tests can hopefully never open.
   ASSERT_TRUE(funnel.InitImpl(kRegistryPath, 4, base::Time::Now()));
 
   // Each named event can only exist in a single copy.
   ASSERT_TRUE(funnel.RecordEvent(L"One"));
   ASSERT_TRUE(funnel.RecordEvent(L"One"));
   ASSERT_TRUE(funnel.RecordEvent(L"One"));
   ASSERT_TRUE(funnel.RecordEvent(L"Two"));
   ASSERT_TRUE(funnel.RecordEvent(L"Three"));
 
-  WatcherMetricsProviderWin provider(kRegistryPath);
+  WatcherMetricsProviderWin provider(kRegistryPath, true);
 
   provider.ProvideStabilityMetrics(NULL);
   histogram_tester_.ExpectTotalCount("Stability.ExitFunnel.One", 1);
   histogram_tester_.ExpectTotalCount("Stability.ExitFunnel.Two", 1);
   histogram_tester_.ExpectTotalCount("Stability.ExitFunnel.Three", 1);
 
   // Make sure the subkey for the pseudo process has been deleted on reporting.
   base::win::RegistryKeyIterator it(HKEY_CURRENT_USER, kRegistryPath);
   ASSERT_EQ(it.SubkeyCount(), 1);
 }
 
+TEST_F(WatcherMetricsProviderWinTest, ClearsExitFunnelWriteWhenNotReporting) {
+  // Test that the metrics provider picks up the writes from

[Alexei Svitkine (slow), 2015/01/23 18:45:22]

Incomplete sentence?

[Sigurður Ásgeirsson, 2015/01/23 18:48:43]

Done.

+  ExitFunnel funnel;
+
+  // Events against our own process should not get reported.
+  ASSERT_TRUE(funnel.Init(kRegistryPath, base::GetCurrentProcessHandle()));
+  ASSERT_TRUE(funnel.RecordEvent(L"Forgetaboutit"));
+
+  // Reset the funnel to a pseudo process. The PID 4 is the system process,
+  // which tests can hopefully never open.
+  ASSERT_TRUE(funnel.InitImpl(kRegistryPath, 4, base::Time::Now()));
+
+  // Each named event can only exist in a single copy.
+  ASSERT_TRUE(funnel.RecordEvent(L"One"));
+  ASSERT_TRUE(funnel.RecordEvent(L"One"));
+  ASSERT_TRUE(funnel.RecordEvent(L"One"));
+  ASSERT_TRUE(funnel.RecordEvent(L"Two"));
+  ASSERT_TRUE(funnel.RecordEvent(L"Three"));
+
+  // Turn off exit funnel reporting.
+  WatcherMetricsProviderWin provider(kRegistryPath, false);
+
+  provider.ProvideStabilityMetrics(NULL);
+  histogram_tester_.ExpectTotalCount("Stability.ExitFunnel.One", 0);
+  histogram_tester_.ExpectTotalCount("Stability.ExitFunnel.Two", 0);
+  histogram_tester_.ExpectTotalCount("Stability.ExitFunnel.Three", 0);
+
+  // Make sure the subkey for the pseudo process has been deleted on reporting.
+  base::win::RegistryKeyIterator it(HKEY_CURRENT_USER, kRegistryPath);
+  ASSERT_EQ(it.SubkeyCount(), 1);
+}
+
 }  // namespace browser_watcher