Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 868143004: Add an explicit ObjectWatcher::IsWatching() method (Closed)

Created:
5 years, 10 months ago by rvargas (doing something else)
Modified:
5 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an explicit ObjectWatcher::IsWatching() method This removes the need to compare a raw handle against a predefined value from the caller's code. BUG=none TEST=base_unittests Committed: https://crrev.com/51f3aacf25ac2246a2ea5e346a2e4962da2544d6 Cr-Commit-Position: refs/heads/master@{#314687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M base/win/object_watcher.h View 1 chunk +5 lines, -3 lines 0 comments Download
M base/win/object_watcher.cc View 1 chunk +5 lines, -1 line 0 comments Download
M base/win/object_watcher_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rvargas (doing something else)
5 years, 10 months ago (2015-02-04 03:22:21 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 10 months ago (2015-02-05 00:31:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868143004/1
5 years, 10 months ago (2015-02-05 00:44:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 00:49:21 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 00:51:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51f3aacf25ac2246a2ea5e346a2e4962da2544d6
Cr-Commit-Position: refs/heads/master@{#314687}

Powered by Google App Engine
This is Rietveld 408576698