Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2112)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 868123002: Reset gesture detection upon page navigation for Aura (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename the method Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 3a7de61f05a3f6429c910799dac55622fb0e4753..4c9b5240070a888871dd94106d73d0ba5c2db5c6 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -815,7 +815,7 @@ bool RenderWidgetHostViewAndroid::OnTouchHandleEvent(
selection_controller_->WillHandleTouchEvent(event);
}
-void RenderWidgetHostViewAndroid::ResetGestureDetection() {
+void RenderWidgetHostViewAndroid::OnMainFrameNavigation() {
const ui::MotionEvent* current_down_event =
gesture_provider_.GetCurrentDownEvent();
if (current_down_event) {
@@ -1258,7 +1258,7 @@ void RenderWidgetHostViewAndroid::OnSelectionEvent(
// space. Avoid the associated scroll jump by pre-emptively cancelling gesture
// detection; scrolling after the selection is activated is unnecessary.
if (event == ui::SelectionEventType::SELECTION_SHOWN)
- ResetGestureDetection();
+ OnMainFrameNavigation();
sadrul 2015/02/03 01:26:16 This feels wrong? Perhaps have ResetGestureDetecto
lanwei 2015/02/04 21:10:05 Done.
content_view_core_->OnSelectionEvent(event, position);
}

Powered by Google App Engine
This is Rietveld 408576698