Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 868093002: Revert "Make version generation robust to other user-defined tags." (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Make version generation robust to other user-defined tags." This reverts commit 9ae1c2382a35147d7f4aeba3ecd2030123f0d5fb. BUG=chromium:446166 LOG=n NOTRY=true TBR=jkummerow@chromium.org Committed: https://crrev.com/bf41bde9f99dbb3ce10b9316625c0d963c5c400b Cr-Commit-Position: refs/heads/master@{#26254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M src/version.cc View 2 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Leftovers
5 years, 11 months ago (2015-01-23 15:27:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868093002/1
5 years, 11 months ago (2015-01-23 15:28:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 15:29:15 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 15:29:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf41bde9f99dbb3ce10b9316625c0d963c5c400b
Cr-Commit-Position: refs/heads/master@{#26254}

Powered by Google App Engine
This is Rietveld 408576698