Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 868023005: Fix variable shadowing warning in safe_sprintf in VS2015 (Closed)

Created:
5 years, 11 months ago by scottmg
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2015-threading
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix variable shadowing warning in safe_sprintf in VS2015 d:\src\cr3\src\base\strings\safe_sprintf.cc(513): error C2220: warning treated as error - no 'object' file generated d:\src\cr3\src\base\strings\safe_sprintf.cc(513): warning C4456: declaration of 'ch' hides previous local declaration d:\src\cr3\src\base\strings\safe_sprintf.cc(450): note: see declaration of 'ch' R=thestig@chromium.org BUG=440500 Committed: https://crrev.com/3c598102874c539a4b5e7f9bc51f624f245827dc Cr-Commit-Position: refs/heads/master@{#313343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M base/strings/safe_sprintf.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
5 years, 11 months ago (2015-01-27 19:19:16 UTC) #1
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-27 19:36:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868023005/1
5 years, 11 months ago (2015-01-27 20:16:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 20:22:00 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 20:23:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c598102874c539a4b5e7f9bc51f624f245827dc
Cr-Commit-Position: refs/heads/master@{#313343}

Powered by Google App Engine
This is Rietveld 408576698