Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 867963006: Add the <t> element and ignore whitespace outside it. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add the <t> element and ignore whitespace outside it. We now only preserve the whitespace inside a <t> element inside the parser. This removes the known n^2 from reattaching whitespace which should make parsing and appending nodes faster. I also removed the dead WhitespaceMode code from the parser, and made the dom-seralizer.sky auto indent the markup so the test output would be readable. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a19a04db3d662adac5707e9f62e8fae098b327b7

Patch Set 1 #

Patch Set 2 : don't mess with Text::needsWhitespaceRenderer. #

Patch Set 3 : Do it for a whole subtree. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -337 lines) Patch
M sky/engine/core/core.gni View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M sky/engine/core/dom/Element.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/Element.cpp View 4 chunks +4 lines, -14 lines 0 comments Download
M sky/engine/core/dom/Node.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Node.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M sky/engine/core/dom/Text.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/Text.cpp View 1 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
A sky/engine/core/html/HTMLTElement.h View 1 chunk +26 lines, -0 lines 0 comments Download
A sky/engine/core/html/HTMLTElement.cpp View 1 chunk +27 lines, -0 lines 0 comments Download
A + sky/engine/core/html/HTMLTElement.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M sky/engine/core/html/HTMLTagNames.in View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/html/parser/HTMLConstructionSite.h View 4 chunks +3 lines, -16 lines 0 comments Download
M sky/engine/core/html/parser/HTMLConstructionSite.cpp View 1 2 4 chunks +18 lines, -16 lines 0 comments Download
M sky/engine/core/html/parser/HTMLElementStack.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/html/parser/HTMLElementStack.cpp View 1 2 3 chunks +8 lines, -0 lines 0 comments Download
M sky/examples/city-list/city-list.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/dom-serializer.sky View 3 chunks +40 lines, -20 lines 0 comments Download
M sky/tests/framework/binding-expected.txt View 1 chunk +13 lines, -17 lines 0 comments Download
M sky/tests/framework/citylist-expected.txt View 1 chunk +54 lines, -54 lines 0 comments Download
M sky/tests/framework/citylist-scrolled-expected.txt View 1 chunk +51 lines, -51 lines 0 comments Download
M sky/tests/lowlevel/abarth-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tests/parser/control-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/parser/endtag-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M sky/tests/parser/entity-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
M sky/tests/parser/html-expected.txt View 2 chunks +13 lines, -6 lines 0 comments Download
M sky/tests/parser/script-expected.txt View 1 chunk +15 lines, -24 lines 0 comments Download
M sky/tests/parser/starttag-expected.txt View 1 chunk +15 lines, -19 lines 0 comments Download
M sky/tests/parser/style-expected.txt View 4 chunks +11 lines, -17 lines 0 comments Download
M sky/tests/parser/voidtag-expected.txt View 1 chunk +9 lines, -21 lines 0 comments Download
A sky/tests/parser/whitespace.sky View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A sky/tests/parser/whitespace-expected.txt View 1 2 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-24 00:28:30 UTC) #1
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-24 00:46:47 UTC) #2
esprehn
5 years, 11 months ago (2015-01-24 00:50:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:2) manually as
a19a04db3d662adac5707e9f62e8fae098b327b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698