Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 867903006: IPC Fuzzer: Initialize mojo in the replay process. (Closed)

Created:
5 years, 10 months ago by Hajime Morrita
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez, inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IPC Fuzzer: Initialize mojo in the replay process. Without this, ChannelMojo doesn't work. R=inferno@chromium.org, tsepez@chromium.org TBR=jamesr@chromium.org BUG=453571 Committed: https://crrev.com/a89461fe15779ec8e939f2b16acd282155c42ab1 Cr-Commit-Position: refs/heads/master@{#314010}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Landing #

Patch Set 3 : Adding TBR to a Mojo owner. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M tools/ipc_fuzzer/replay/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M tools/ipc_fuzzer/replay/replay_process.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (5 generated)
Hajime Morrita
5 years, 10 months ago (2015-01-30 20:38:53 UTC) #1
inferno
https://codereview.chromium.org/867903006/diff/1/tools/ipc_fuzzer/replay/replay_process.cc File tools/ipc_fuzzer/replay/replay_process.cc (right): https://codereview.chromium.org/867903006/diff/1/tools/ipc_fuzzer/replay/replay_process.cc#newcode25 tools/ipc_fuzzer/replay/replay_process.cc:25: void InitializeMojo() { Why do we need to duplicate ...
5 years, 10 months ago (2015-01-30 20:42:22 UTC) #2
Hajime Morrita
On 2015/01/30 20:42:22, inferno wrote: > https://codereview.chromium.org/867903006/diff/1/tools/ipc_fuzzer/replay/replay_process.cc > File tools/ipc_fuzzer/replay/replay_process.cc (right): > > https://codereview.chromium.org/867903006/diff/1/tools/ipc_fuzzer/replay/replay_process.cc#newcode25 > ...
5 years, 10 months ago (2015-01-30 21:07:35 UTC) #3
Tom Sepez
LGTM. Note that another possiblity might be to make the replay process inherit from content::ChildProcess ...
5 years, 10 months ago (2015-01-30 21:15:52 UTC) #4
inferno
On 2015/01/30 21:07:35, morrita wrote: > On 2015/01/30 20:42:22, inferno wrote: > > > https://codereview.chromium.org/867903006/diff/1/tools/ipc_fuzzer/replay/replay_process.cc ...
5 years, 10 months ago (2015-01-30 21:31:08 UTC) #5
Hajime Morrita
On 2015/01/30 21:31:08, inferno wrote: > On 2015/01/30 21:07:35, morrita wrote: > > On 2015/01/30 ...
5 years, 10 months ago (2015-01-30 21:37:53 UTC) #6
Hajime Morrita
On 2015/01/30 21:15:52, Tom Sepez wrote: > LGTM. Note that another possiblity might be to ...
5 years, 10 months ago (2015-01-30 21:39:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867903006/20001
5 years, 10 months ago (2015-01-30 21:39:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39560)
5 years, 10 months ago (2015-01-30 21:46:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867903006/40001
5 years, 10 months ago (2015-01-30 21:54:18 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39567)
5 years, 10 months ago (2015-01-30 22:00:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867903006/40001
5 years, 10 months ago (2015-01-30 22:03:37 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-30 22:37:14 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 22:38:17 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a89461fe15779ec8e939f2b16acd282155c42ab1
Cr-Commit-Position: refs/heads/master@{#314010}

Powered by Google App Engine
This is Rietveld 408576698