Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 867903004: MSan: disallow uninitialized data in GLES2Implementation::BufferDataHelper. (Closed)

Created:
5 years, 10 months ago by earthdok
Modified:
5 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MSan: disallow uninitialized data in GLES2Implementation::BufferDataHelper. MSan doesn't undestand shared memory, so a buffer that has been tainted with uninitialized values would still be considered uninitialized even after a write on the other end (the GPU). This results in confusing uninit reports in the renderer after readback. Doing an explicit check early should make those reports less confusing and less flaky. We might even find some real bugs! BUG=445745 R=zmo@chromium.org Committed: https://crrev.com/c0d26f39a0d4a98f271e13c46d143bac1eb0e9e0 Cr-Commit-Position: refs/heads/master@{#314098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M gpu/command_buffer/client/gles2_implementation.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
earthdok
please take a look
5 years, 10 months ago (2015-01-30 18:54:53 UTC) #1
Zhenyao Mo
On 2015/01/30 18:54:53, earthdok wrote: > please take a look LGTM
5 years, 10 months ago (2015-01-30 20:07:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867903004/1
5 years, 10 months ago (2015-01-30 20:08:59 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/29026)
5 years, 10 months ago (2015-01-30 21:20:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867903004/1
5 years, 10 months ago (2015-02-01 23:03:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-01 23:42:55 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-01 23:44:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0d26f39a0d4a98f271e13c46d143bac1eb0e9e0
Cr-Commit-Position: refs/heads/master@{#314098}

Powered by Google App Engine
This is Rietveld 408576698