| Index: sky/engine/core/frame/PRESUBMIT.py
|
| diff --git a/sky/engine/core/frame/PRESUBMIT.py b/sky/engine/core/frame/PRESUBMIT.py
|
| index 0f89ba27695ef8d9e6d821c814a109755e929ab9..425fe5dc3fe92dfcc33ffaa9c716d6c1195134b0 100644
|
| --- a/sky/engine/core/frame/PRESUBMIT.py
|
| +++ b/sky/engine/core/frame/PRESUBMIT.py
|
| @@ -9,49 +9,9 @@ for more details about the presubmit API built into gcl.
|
| """
|
|
|
|
|
| -def _RunUseCounterChecks(input_api, output_api):
|
| - for f in input_api.AffectedFiles():
|
| - if f.LocalPath().endswith('UseCounter.cpp'):
|
| - useCounterCpp = f
|
| - break
|
| - else:
|
| - return []
|
| -
|
| - largestFoundBucket = 0
|
| - maximumBucket = 0
|
| - # Looking for a line like "case CSSPropertyFoo: return 453;"
|
| - bucketFinder = input_api.re.compile(r'.*CSSProperty.*return\s*([0-9]+).*')
|
| - # Looking for a line like "static int maximumCSSSampleId() { return 452; }"
|
| - maximumFinder = input_api.re.compile(
|
| - r'static int maximumCSSSampleId\(\) { return ([0-9]+)')
|
| - for line in useCounterCpp.NewContents():
|
| - bucketMatch = bucketFinder.match(line)
|
| - if bucketMatch:
|
| - bucket = int(bucketMatch.group(1))
|
| - largestFoundBucket = max(largestFoundBucket, bucket)
|
| - else:
|
| - maximumMatch = maximumFinder.match(line)
|
| - if maximumMatch:
|
| - maximumBucket = int(maximumMatch.group(1))
|
| -
|
| - if largestFoundBucket != maximumBucket:
|
| - if input_api.is_committing:
|
| - message_type = output_api.PresubmitError
|
| - else:
|
| - message_type = output_api.PresubmitPromptWarning
|
| -
|
| - return [message_type(
|
| - 'Largest found CSSProperty bucket Id (%d) does not match '
|
| - 'maximumCSSSampleId (%d)' %
|
| - (largestFoundBucket, maximumBucket),
|
| - items=[useCounterCpp.LocalPath()])]
|
| -
|
| - return []
|
| -
|
| -
|
| def CheckChangeOnUpload(input_api, output_api):
|
| - return _RunUseCounterChecks(input_api, output_api)
|
| + return []
|
|
|
|
|
| def CheckChangeOnCommit(input_api, output_api):
|
| - return _RunUseCounterChecks(input_api, output_api)
|
| + return []
|
|
|