Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: sky/engine/bindings/templates/attributes.cpp

Issue 867903002: Remove UseCounter (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {##############################################################################} 1 {##############################################################################}
2 {% macro attribute_getter(attribute, world_suffix) %} 2 {% macro attribute_getter(attribute, world_suffix) %}
3 {% filter conditional(attribute.conditional_string) %} 3 {% filter conditional(attribute.conditional_string) %}
4 static void {{attribute.name}}AttributeGetter{{world_suffix}}( 4 static void {{attribute.name}}AttributeGetter{{world_suffix}}(
5 {%- if attribute.is_expose_js_accessors %} 5 {%- if attribute.is_expose_js_accessors %}
6 const v8::FunctionCallbackInfo<v8::Value>& info 6 const v8::FunctionCallbackInfo<v8::Value>& info
7 {%- else %} 7 {%- else %}
8 const v8::PropertyCallbackInfo<v8::Value>& info 8 const v8::PropertyCallbackInfo<v8::Value>& info
9 {%- endif %}) 9 {%- endif %})
10 { 10 {
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 {% macro attribute_getter_callback(attribute, world_suffix) %} 139 {% macro attribute_getter_callback(attribute, world_suffix) %}
140 {% filter conditional(attribute.conditional_string) %} 140 {% filter conditional(attribute.conditional_string) %}
141 static void {{attribute.name}}AttributeGetterCallback{{world_suffix}}( 141 static void {{attribute.name}}AttributeGetterCallback{{world_suffix}}(
142 {%- if attribute.is_expose_js_accessors %} 142 {%- if attribute.is_expose_js_accessors %}
143 const v8::FunctionCallbackInfo<v8::Value>& info 143 const v8::FunctionCallbackInfo<v8::Value>& info
144 {%- else %} 144 {%- else %}
145 v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info 145 v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info
146 {%- endif %}) 146 {%- endif %})
147 { 147 {
148 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter"); 148 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");
149 {% if attribute.deprecate_as %}
150 UseCounter::countDeprecation(callingExecutionContext(info.GetIsolate()), Use Counter::{{attribute.deprecate_as}});
151 {% endif %}
152 {% if attribute.measure_as %}
153 UseCounter::count(callingExecutionContext(info.GetIsolate()), UseCounter::{{ attribute.measure_as}});
154 {% endif %}
155 {% if attribute.has_custom_getter %} 149 {% if attribute.has_custom_getter %}
156 {{v8_class}}::{{attribute.name}}AttributeGetterCustom(info); 150 {{v8_class}}::{{attribute.name}}AttributeGetterCustom(info);
157 {% else %} 151 {% else %}
158 {{cpp_class}}V8Internal::{{attribute.name}}AttributeGetter{{world_suffix}}(i nfo); 152 {{cpp_class}}V8Internal::{{attribute.name}}AttributeGetter{{world_suffix}}(i nfo);
159 {% endif %} 153 {% endif %}
160 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution"); 154 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
161 } 155 }
162 {% endfilter %} 156 {% endfilter %}
163 {% endmacro %} 157 {% endmacro %}
164 158
165 159
166 {##############################################################################} 160 {##############################################################################}
167 {% macro constructor_getter_callback(attribute, world_suffix) %} 161 {% macro constructor_getter_callback(attribute, world_suffix) %}
168 {% filter conditional(attribute.conditional_string) %} 162 {% filter conditional(attribute.conditional_string) %}
169 static void {{attribute.name}}ConstructorGetterCallback{{world_suffix}}(v8::Loca l<v8::String> property, const v8::PropertyCallbackInfo<v8::Value>& info) 163 static void {{attribute.name}}ConstructorGetterCallback{{world_suffix}}(v8::Loca l<v8::String> property, const v8::PropertyCallbackInfo<v8::Value>& info)
170 { 164 {
171 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter"); 165 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");
172 {% if attribute.deprecate_as %}
173 UseCounter::countDeprecation(callingExecutionContext(info.GetIsolate()), Use Counter::{{attribute.deprecate_as}});
174 {% endif %}
175 {% if attribute.measure_as %}
176 UseCounter::count(callingExecutionContext(info.GetIsolate()), UseCounter::{{ attribute.measure_as}});
177 {% endif %}
178 {{cpp_class}}V8Internal::{{cpp_class}}ConstructorGetter{{world_suffix}}(prop erty, info); 166 {{cpp_class}}V8Internal::{{cpp_class}}ConstructorGetter{{world_suffix}}(prop erty, info);
179 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution"); 167 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
180 } 168 }
181 {% endfilter %} 169 {% endfilter %}
182 {% endmacro %} 170 {% endmacro %}
183 171
184 172
185 {##############################################################################} 173 {##############################################################################}
186 {% macro attribute_setter(attribute, world_suffix) %} 174 {% macro attribute_setter(attribute, world_suffix) %}
187 {% filter conditional(attribute.conditional_string) %} 175 {% filter conditional(attribute.conditional_string) %}
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 {%- if attribute.is_expose_js_accessors %} 270 {%- if attribute.is_expose_js_accessors %}
283 const v8::FunctionCallbackInfo<v8::Value>& info 271 const v8::FunctionCallbackInfo<v8::Value>& info
284 {%- else %} 272 {%- else %}
285 v8::Local<v8::String>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackI nfo<void>& info 273 v8::Local<v8::String>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackI nfo<void>& info
286 {%- endif %}) 274 {%- endif %})
287 { 275 {
288 {% if attribute.is_expose_js_accessors %} 276 {% if attribute.is_expose_js_accessors %}
289 v8::Local<v8::Value> v8Value = info[0]; 277 v8::Local<v8::Value> v8Value = info[0];
290 {% endif %} 278 {% endif %}
291 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter"); 279 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter");
292 {% if attribute.deprecate_as %}
293 UseCounter::countDeprecation(callingExecutionContext(info.GetIsolate()), Use Counter::{{attribute.deprecate_as}});
294 {% endif %}
295 {% if attribute.measure_as %}
296 UseCounter::count(callingExecutionContext(info.GetIsolate()), UseCounter::{{ attribute.measure_as}});
297 {% endif %}
298 {% if attribute.is_custom_element_callbacks or attribute.is_reflect %} 280 {% if attribute.is_custom_element_callbacks or attribute.is_reflect %}
299 CustomElementProcessingStack::CallbackDeliveryScope deliveryScope; 281 CustomElementProcessingStack::CallbackDeliveryScope deliveryScope;
300 {% endif %} 282 {% endif %}
301 {% if attribute.has_custom_setter %} 283 {% if attribute.has_custom_setter %}
302 {{v8_class}}::{{attribute.name}}AttributeSetterCustom(v8Value, info); 284 {{v8_class}}::{{attribute.name}}AttributeSetterCustom(v8Value, info);
303 {% else %} 285 {% else %}
304 {{cpp_class}}V8Internal::{{attribute.name}}AttributeSetter{{world_suffix}}(v 8Value, info); 286 {{cpp_class}}V8Internal::{{attribute.name}}AttributeSetter{{world_suffix}}(v 8Value, info);
305 {% endif %} 287 {% endif %}
306 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution"); 288 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
307 } 289 }
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 access_control, 397 access_control,
416 property_attribute, 398 property_attribute,
417 only_exposed_to_private_script, 399 only_exposed_to_private_script,
418 ] %} 400 ] %}
419 {% if not attribute.is_expose_js_accessors %} 401 {% if not attribute.is_expose_js_accessors %}
420 {% set attribute_configuration_list = attribute_configuration_list 402 {% set attribute_configuration_list = attribute_configuration_list
421 + [on_prototype] %} 403 + [on_prototype] %}
422 {% endif %} 404 {% endif %}
423 {{'{'}}{{attribute_configuration_list | join(', ')}}{{'}'}} 405 {{'{'}}{{attribute_configuration_list | join(', ')}}{{'}'}}
424 {%- endmacro %} 406 {%- endmacro %}
OLDNEW
« no previous file with comments | « sky/engine/bindings/scripts/v8_utilities.py ('k') | sky/engine/bindings/templates/interface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698