Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: tools/testing/test_configuration.py

Issue 8679025: Fix handling of VMOptions= in multi tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/test_configuration.py
diff --git a/tools/testing/test_configuration.py b/tools/testing/test_configuration.py
index 8177d191a0c32392f2cfec1ff673cd9c30060e52..806549e1be3637aacbe0a2f3dedca9e2609d2e74 100644
--- a/tools/testing/test_configuration.py
+++ b/tools/testing/test_configuration.py
@@ -88,12 +88,21 @@ class StandardTestConfiguration(test.TestConfiguration):
kind, test_source = tags[tag]
if not self.Contains(path, test_path + [tag]):
continue
- tests.append(test_case.MultiTestCase(self.context,
- test_path + [tag],
- test_source,
- kind,
- mode, arch, component,
- self.flags))
+ if vm_options_list:
+ for options in vm_options_list:
+ tests.append(test_case.MultiTestCase(self.context,
+ test_path + [tag],
+ test_source,
+ kind,
+ mode, arch, component,
+ options + self.flags))
+ else:
+ tests.append(test_case.MultiTestCase(self.context,
+ test_path + [tag],
+ test_source,
+ kind,
+ mode, arch, component,
+ self.flags))
else:
if vm_options_list:
for options in vm_options_list:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698