Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 867853002: Fix prototype for WebFrameClient::createChildFrame() in android_webview. (Closed)

Created:
5 years, 11 months ago by alexmos
Modified:
5 years, 11 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix prototype for WebFrameClient::createChildFrame() in android_webview. WebFrameClient::createChildFrame() is being updated to take SandboxFlags. See https://codereview.chromium.org/837283003/ for more details. BUG=426512 TBR=mkosiba Committed: https://crrev.com/e3a5f152ba4c6daac579b5f801a723415eb24241 Cr-Commit-Position: refs/heads/master@{#312758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M android_webview/renderer/print_web_view_helper.cc View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Peter Kasting
LGTM
5 years, 11 months ago (2015-01-23 00:41:32 UTC) #3
alexmos
TBRing mkosiba@ for OWNERs approval, as this is hopefully a trivial change that's currently blocking ...
5 years, 11 months ago (2015-01-23 00:44:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867853002/1
5 years, 11 months ago (2015-01-23 00:44:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 03:20:24 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 03:21:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3a5f152ba4c6daac579b5f801a723415eb24241
Cr-Commit-Position: refs/heads/master@{#312758}

Powered by Google App Engine
This is Rietveld 408576698