Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 867843002: Revert of Make RenderFrame(Host) own a RenderWidget(Host). (Closed)

Created:
5 years, 11 months ago by Peter Kasting
Modified:
5 years, 11 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, nasko+codewatch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make RenderFrame(Host) own a RenderWidget(Host). (patchset #21 id:400001 of https://codereview.chromium.org/616133002/) Reason for revert: Broke Blink Mac dbg compile: http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/72778/steps/compile/logs/stdio This error seems somewhat odd; the patch looks correct to me, so I'm not sure why the linker is giving missing symbol errors. Original issue's description: > Make RenderFrame(Host) own a RenderWidget(Host). > > When a RenderFrameHost is created for an out-of-process iframe, it > will create a RenderWidgetHost to manage rendering and input events for > the iframe and its same-process frame descendants. A corresponding > RenderWidget is created in the renderer process. > > BUG=419087 > > Committed: https://crrev.com/2dfb76d84f4ebde602c1c3cde700dcf71b4d1bd6 > Cr-Commit-Position: refs/heads/master@{#312451} > > Committed: https://crrev.com/a719983b5525a477724350ee9eba20e574d0eb3b > Cr-Commit-Position: refs/heads/master@{#312702} TBR=creis@chromium.org,nasko@chromium.org,nick@chromium.org,dmazzoni@chromium.org,kenrb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=419087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -314 lines) Patch
M content/browser/frame_host/frame_tree_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_factory.h View 3 chunks +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_factory.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 6 chunks +6 lines, -26 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 8 chunks +4 lines, -63 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 12 chunks +25 lines, -36 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 2 chunks +0 lines, -16 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 5 chunks +5 lines, -26 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/frame_messages.h View 2 chunks +2 lines, -16 lines 0 comments Download
M content/renderer/render_frame_impl.h View 4 chunks +1 line, -12 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 4 chunks +1 line, -25 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/render_widget.h View 3 chunks +0 lines, -17 lines 0 comments Download
M content/renderer/render_widget.cc View 4 chunks +2 lines, -40 lines 0 comments Download
M content/test/test_render_frame_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_render_frame_host.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/test_render_frame_host_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_render_frame_host_factory.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Kasting
Created Revert of Make RenderFrame(Host) own a RenderWidget(Host).
5 years, 11 months ago (2015-01-23 00:26:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867843002/1
5 years, 11 months ago (2015-01-23 00:28:40 UTC) #2
dcheng
The followup builds look fine: http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/ Does this really need to be reverted?
5 years, 11 months ago (2015-01-23 00:30:27 UTC) #6
dcheng
Here's a previous time I had an issue with the Mac builders failing for no ...
5 years, 11 months ago (2015-01-23 00:32:21 UTC) #7
Peter Kasting
5 years, 11 months ago (2015-01-23 00:39:06 UTC) #8
Closing.

Powered by Google App Engine
This is Rietveld 408576698