Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 867823007: Make the scroll_delta flooring behavior the same as before SyncedProperty change (Closed)

Created:
5 years, 10 months ago by Yufeng Shen (Slow to review)
Modified:
5 years, 10 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the scroll_delta flooring behavior the same as before SyncedProperty change Impl sents truncated ScrollDelta to main. Recent change to use SyncedProperty changes the truncation behavior in the case when scroll_offset(active_base) is non-integer. This CL restores the behavior. The whole flooring will be gone soon when we are able to send non-integer scroll delta to main. This CL is only meant to make sure that SyncedProperty switch has no functional change. BUG= Committed: https://crrev.com/3b4800d42ead0f0ff9420755af741e79613d4a01 Cr-Commit-Position: refs/heads/master@{#314237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M cc/layers/layer_impl.cc View 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
miletus1
5 years, 10 months ago (2015-02-02 22:55:04 UTC) #3
aelias_OOO_until_Jul13
lgtm
5 years, 10 months ago (2015-02-02 23:03:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867823007/1
5 years, 10 months ago (2015-02-02 23:25:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 01:36:38 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 01:37:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b4800d42ead0f0ff9420755af741e79613d4a01
Cr-Commit-Position: refs/heads/master@{#314237}

Powered by Google App Engine
This is Rietveld 408576698