Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 867803004: [PATCH 4/11] ozone: evdev: Move EventModifiersEvdev usage to EventFactoryEvdev (Closed)

Created:
5 years, 11 months ago by spang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Move EventModifiersEvdev usage to EventFactoryEvdev This is part of a series moving IO on evdev devices to a fast thread, since UI thread is too slow for the cursor. EventModifiersEvdev is a UI thread object, so move all remaining ui::Event construction outside of the device-specific objects. Devices no longer get a EventModifiersEvdev* since they will execute on a different thread. This completes the series moving ui::Event construction out of device objects and into EventFactoryEvdev. BUG=449710 TEST=boot link_freon & click mouse Committed: https://crrev.com/c21dfe902bc2da191d73f154406acc3e4b38d952 Cr-Commit-Position: refs/heads/master@{#313464}

Patch Set 1 #

Patch Set 2 : updates for events_unittests #

Patch Set 3 : update per comments on previous patches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -167 lines) Patch
M ui/events/ozone/evdev/event_converter_evdev_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc View 1 3 chunks +1 line, -3 lines 0 comments Download
M ui/events/ozone/evdev/event_dispatch_callback.h View 1 2 3 chunks +40 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_dispatch_callback.cc View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 2 6 chunks +33 lines, -12 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h View 5 chunks +4 lines, -8 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 1 2 7 chunks +24 lines, -52 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev.h View 2 chunks +12 lines, -13 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev.cc View 1 2 4 chunks +13 lines, -18 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc View 1 12 chunks +94 lines, -52 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
spang
5 years, 11 months ago (2015-01-23 21:57:56 UTC) #2
alexst (slow to review)
lgtm
5 years, 11 months ago (2015-01-27 16:01:07 UTC) #3
spang
5 years, 11 months ago (2015-01-27 19:33:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867803004/40001
5 years, 10 months ago (2015-01-28 08:22:55 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-28 08:54:20 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 08:55:28 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c21dfe902bc2da191d73f154406acc3e4b38d952
Cr-Commit-Position: refs/heads/master@{#313464}

Powered by Google App Engine
This is Rietveld 408576698