sync/syncable/entry_kernel.h - Issue 867793003: Remove dependency on server generated type root folders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/entry_kernel.h

Issue 867793003: Remove dependency on server generated type root folders (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added extra comment about existing type root folder. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/syncable/entry_kernel.h

diff --git a/sync/syncable/entry_kernel.h b/sync/syncable/entry_kernel.h

index f5c40175c336f00f0997d3d18e5c39c332c3fafa..0c2f47133264df605bbaef4aae0e9796c7ef0341 100644

--- a/sync/syncable/entry_kernel.h

+++ b/sync/syncable/entry_kernel.h

@@ -247,7 +247,6 @@ struct SYNC_EXPORT_PRIVATE EntryKernel {

ProtoTimeToTime(TimeToProtoTime(value));

}

inline void put(IdField field, const Id& value) {

- DCHECK(!value.IsNull());

id_fields[field - ID_FIELDS_BEGIN] = value;

}

inline void put(BaseVersion field, int64 value) {

« no previous file with comments | « sync/syncable/directory_unittest.cc ('k') | sync/syncable/entry_kernel.cc » ('j') | no next file with comments »