Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 867793002: Update {virtual,override,final} to follow C++11 style in net, round 2. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
eroman
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in net, round 2. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Committed: https://crrev.com/8ccc40cc9bf1d9bb5a83e7ac49a3802d665f12d3 Cr-Commit-Position: refs/heads/master@{#312739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -26 lines) Patch
M net/cert/nss_cert_database_chromeos.h View 1 chunk +5 lines, -7 lines 0 comments Download
M net/cert/nss_cert_database_chromeos_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/cert/nss_profile_filter_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_service.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M net/ssl/client_cert_store_chromeos.h View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
5 years, 11 months ago (2015-01-22 22:34:36 UTC) #2
eroman
lgtm
5 years, 11 months ago (2015-01-22 23:03:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867793002/1
5 years, 11 months ago (2015-01-22 23:05:21 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-23 01:08:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867793002/1
5 years, 11 months ago (2015-01-23 01:17:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 01:48:27 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 01:49:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ccc40cc9bf1d9bb5a83e7ac49a3802d665f12d3
Cr-Commit-Position: refs/heads/master@{#312739}

Powered by Google App Engine
This is Rietveld 408576698