Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 867623005: chromeos: Remove unneeded geometry dependency from both GYP and GN. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
jonross, oshima
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Remove unneeded geometry dependency from both GYP and GN. Looks like these were missed in https://chromium.googlesource.com/chromium/src/+/c47d12e291954bd4fe75504b72e2dbcf667b30a3 And update a few references to ui/accelerometer. BUG=431865 R=oshima@chromium.org Committed: https://crrev.com/7353831d9f7e37f9348cb7c2af601df1000b8b8b Cr-Commit-Position: refs/heads/master@{#314810}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chromeos/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/accelerometer/accelerometer_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/chromeos.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
tfarina
Oshima -> OWNERS approval! Jonathan -> fyi!
5 years, 10 months ago (2015-02-04 20:59:14 UTC) #1
jonross
On 2015/02/04 20:59:14, tfarina wrote: > Oshima -> OWNERS approval! > > Jonathan -> fyi! ...
5 years, 10 months ago (2015-02-04 21:41:03 UTC) #2
oshima
lgtm
5 years, 10 months ago (2015-02-04 22:07:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867623005/1
5 years, 10 months ago (2015-02-04 23:04:31 UTC) #5
commit-bot: I haz the power
Failed to apply the patch.
5 years, 10 months ago (2015-02-04 23:09:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867623005/20001
5 years, 10 months ago (2015-02-05 14:47:45 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 15:22:29 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 15:23:36 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7353831d9f7e37f9348cb7c2af601df1000b8b8b
Cr-Commit-Position: refs/heads/master@{#314810}

Powered by Google App Engine
This is Rietveld 408576698