Source/platform/heap/Heap.h - Issue 867623002: Oilpan: remove too strong start-of-heap-object assert.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/Heap.h

Issue 867623002: Oilpan: remove too strong start-of-heap-object assert. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/Heap.h

diff --git a/Source/platform/heap/Heap.h b/Source/platform/heap/Heap.h

index 0050cb97ada166093406999e01230f26179c8292..434b7b345f7c55e67e5adf759a14fdc0672b5654 100644

--- a/Source/platform/heap/Heap.h

+++ b/Source/platform/heap/Heap.h

@@ -864,10 +864,6 @@ public:

static bool willObjectBeLazilySwept(const T* objectPointer)

{

static_assert(IsGarbageCollectedType<T>::value, "only objects deriving from GarbageCollected can be used.");

-#if ENABLE(ASSERT)

- ASSERT(objectPointer);

- HeapObjectHeader::fromPayload(objectPointer)->checkHeader();

-#endif

#if ENABLE(OILPAN)

BaseHeapPage* page = pageFromObject(objectPointer);

if (page->hasBeenSwept())

« no previous file with comments | « no previous file | no next file » | no next file with comments »