Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 867623002: Oilpan: remove too strong start-of-heap-object assert. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: remove too strong start-of-heap-object assert. Remove the assert checking if willObjectBeLazilySwept()'s argument is a valid reference to the start of a heap object payload. That's too strong a requirement as the argument might be a mixin pointing some way into the payload. Any adjustment needed to get to the object header is taken care of by isHeapObjectAlive(), which will also check the sanity of the object's header. Hence, remove the check from willObjectBeLazilySwept(). TBR=oilpan-reviews,haraken BUG=448392 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/platform/heap/Heap.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sof
Please take a look. My bad, sorry. I should have thought this assert through more ...
5 years, 11 months ago (2015-01-22 13:38:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867623002/1
5 years, 11 months ago (2015-01-22 13:39:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=188812
5 years, 11 months ago (2015-01-22 13:39:47 UTC) #4
haraken
5 years, 11 months ago (2015-01-22 13:39:55 UTC) #5
Message was sent while issue was closed.
On 2015/01/22 13:38:05, sof wrote:
> Please take a look.
> 
> My bad, sorry. I should have thought this assert through more carefully and/or
> run a complete set of tests. Pre-emptively landing.

Thanks for the catch! LGTM.

Powered by Google App Engine
This is Rietveld 408576698