Convert compiler cctest to unit tests, part 1

Convert compiler cctest to unit tests, part 1

R=bmeurer@chromium.org
LOG=n

Committed: https://crrev.com/87e1426ce5d348d5db68bbd9af0efbdbb3b9a4d1
Cr-Commit-Position: refs/heads/master@{#26222}

[danno, 2015-01-22 12:28:38]

PTAL

[Benedikt Meurer, 2015-01-22 13:33:45]

https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/...
File test/unittests/compiler/graph-reducer-unittest.cc (right):

https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/...
test/unittests/compiler/graph-reducer-unittest.cc:22: struct TestOperator :
public Operator {
Please move the TestOperator into the anonymous namespace below.

https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/...
test/unittests/compiler/graph-reducer-unittest.cc:32: const uint8_t OPCODE_A0 =
10;
Can we rename these to kOpcodeA0, etc.

https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/...
test/unittests/compiler/graph-reducer-unittest.cc:32: const uint8_t OPCODE_A0 =
10;
Can we rename these to kOpcodeA0, etc.

https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/...
test/unittests/compiler/graph-reducer-unittest.cc:42: static TestOperator
OPA0(OPCODE_A0, Operator::kNoWrite, "opa1", 0, 1);
Can we rename these to kOpA0, etc.

[danno, 2015-01-22 13:47:45]

feedback addressed

https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/...
File test/unittests/compiler/graph-reducer-unittest.cc (right):

https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/...
test/unittests/compiler/graph-reducer-unittest.cc:22: struct TestOperator :
public Operator {
On 2015/01/22 13:33:44, Benedikt Meurer wrote:
> Please move the TestOperator into the anonymous namespace below.

Done.

https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/...
test/unittests/compiler/graph-reducer-unittest.cc:32: const uint8_t OPCODE_A0 =
10;
On 2015/01/22 13:33:44, Benedikt Meurer wrote:
> Can we rename these to kOpcodeA0, etc.

Done.

https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/...
test/unittests/compiler/graph-reducer-unittest.cc:32: const uint8_t OPCODE_A0 =
10;
On 2015/01/22 13:33:44, Benedikt Meurer wrote:
> Can we rename these to kOpcodeA0, etc.

Done.

https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/...
test/unittests/compiler/graph-reducer-unittest.cc:42: static TestOperator
OPA0(OPCODE_A0, Operator::kNoWrite, "opa1", 0, 1);
On 2015/01/22 13:33:44, Benedikt Meurer wrote:
> Can we rename these to kOpA0, etc.

Done.

[Benedikt Meurer, 2015-01-22 13:49:01]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-01-22 13:49:02]

LGTM

[commit-bot: I haz the power, 2015-01-22 13:49:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/867583002/40001

[titzer, 2015-01-22 14:01:24]

titzer@chromium.org changed reviewers:
+ titzer@chromium.org

[titzer, 2015-01-22 14:01:24]

https://codereview.chromium.org/867583002/diff/40001/test/unittests/compiler/...
File test/unittests/compiler/graph-reducer-unittest.cc (right):

https://codereview.chromium.org/867583002/diff/40001/test/unittests/compiler/...
test/unittests/compiler/graph-reducer-unittest.cc:366: EXPECT_EQ(before,
graph()->NodeCount());
We can also start to use the NodeMatcher infrastructure here, too.

Drop in a TODO?

[commit-bot: I haz the power, 2015-01-22 14:16:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-22 14:17:04]

Patchset 3 (id:??) landed as
https://crrev.com/87e1426ce5d348d5db68bbd9af0efbdbb3b9a4d1
Cr-Commit-Position: refs/heads/master@{#26222}