Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 867493002: Use GuestView embedder when determing the print preview dialog dimensions. (Closed)

Created:
5 years, 11 months ago by Sam McNally
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use GuestView embedder when determing the print preview dialog dimensions. The print preview dialog uses the initiator WebContents to determine its size. For prints from embedded GuestViews, this can cause print preview dialogs to be smaller than normal. This CL fixes this by changing PrintPreviewDialogDelegate::GetDialogSize() to follow the chain of GuestView embedders to find the outermost WebContents and use it to determine the dialog size. BUG=450564 Committed: https://crrev.com/3f44c4635f98d5b4b8f7df70c0e6a503d01e4920 Cr-Commit-Position: refs/heads/master@{#312545}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/browser/printing/print_preview_dialog_controller.cc View 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sam McNally
5 years, 11 months ago (2015-01-22 00:39:16 UTC) #3
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 11 months ago (2015-01-22 00:46:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867493002/20001
5 years, 11 months ago (2015-01-22 00:47:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 11 months ago (2015-01-22 02:51:41 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 02:52:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f44c4635f98d5b4b8f7df70c0e6a503d01e4920
Cr-Commit-Position: refs/heads/master@{#312545}

Powered by Google App Engine
This is Rietveld 408576698