Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: content/browser/accessibility/browser_accessibility_manager_win.cc

Issue 867483008: Add more logging to debug DumpAccessibilityEvent* test failures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment with link to bug Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/browser_accessibility_manager_win.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager_win.cc b/content/browser/accessibility/browser_accessibility_manager_win.cc
index 698f0190d22ce5fd700e3de92e71e435985be788..f62c7c157f9479bd6e15628ed25eaf36c6337bbb 100644
--- a/content/browser/accessibility/browser_accessibility_manager_win.cc
+++ b/content/browser/accessibility/browser_accessibility_manager_win.cc
@@ -76,12 +76,19 @@ IAccessible* BrowserAccessibilityManagerWin::GetParentIAccessible() {
void BrowserAccessibilityManagerWin::MaybeCallNotifyWinEvent(DWORD event,
LONG child_id) {
BrowserAccessibilityDelegate* delegate = GetDelegateFromRootManager();
- if (!delegate)
+ if (!delegate) {
+ // This line and other LOG(WARNING) lines are temporary, to debug
+ // flaky failures in DumpAccessibilityEvent* tests.
+ // http://crbug.com/440579
+ LOG(WARNING) << "Not firing AX event because of no delegate";
return;
+ }
HWND hwnd = delegate->AccessibilityGetAcceleratedWidget();
- if (!hwnd)
+ if (!hwnd) {
+ LOG(WARNING) << "Not firing AX event because of no hwnd";
return;
+ }
::NotifyWinEvent(event, hwnd, OBJID_CLIENT, child_id);
}
@@ -130,8 +137,10 @@ void BrowserAccessibilityManagerWin::NotifyAccessibilityEvent(
ui::AXEvent event_type,
BrowserAccessibility* node) {
BrowserAccessibilityDelegate* root_delegate = GetDelegateFromRootManager();
- if (!root_delegate || !root_delegate->AccessibilityGetAcceleratedWidget())
+ if (!root_delegate || !root_delegate->AccessibilityGetAcceleratedWidget()) {
+ LOG(WARNING) << "Not firing AX event because of no root_delegate or hwnd";
return;
+ }
// Inline text boxes are an internal implementation detail, we don't
// expose them to Windows.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698