Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Issue 867483005: Don't let "aapt crunch" increase image size. (Closed)

Created:
5 years, 10 months ago by newt (away)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't let "aapt crunch" increase image size. For an image that's already optimized, aapt crunch typically increases the image size. In this case, we now use the original image instead of the crunched image. 9-patches, however, must always be crunched, since crunching adds important metadata to the file. Currently, this saves 50KB, but has the potential to save up to 300KB once we optimize all the images in the codebase. BUG=407781 Committed: https://crrev.com/d7e09cdd4322829368cdad8eb33c784912971a77 Cr-Commit-Position: refs/heads/master@{#313656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M build/android/gyp/process_resources.py View 2 chunks +32 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
newt (away)
PTAL
5 years, 10 months ago (2015-01-29 00:54:42 UTC) #2
cjhopman
lgtm
5 years, 10 months ago (2015-01-29 01:01:59 UTC) #3
aurimas (slooooooooow)
lgtm
5 years, 10 months ago (2015-01-29 01:09:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867483005/1
5 years, 10 months ago (2015-01-29 01:21:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 03:04:53 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 03:06:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7e09cdd4322829368cdad8eb33c784912971a77
Cr-Commit-Position: refs/heads/master@{#313656}

Powered by Google App Engine
This is Rietveld 408576698