DescriptionRevert of Eliminate components_unittests' dependence on chrome resources. (patchset #8 id:180001 of https://codereview.chromium.org/856163002/)
Reason for revert:
Causes Mac ASAN bot to fail on BookmarkModelTest.Sort. The failures look the same as those referenced in crbug.com/450464.
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/6320
Original issue's description:
> Eliminate components_unittests' dependence on chrome resources.
>
> This CL changes components_unittests to create its own pakfile rather than
> relying on the chrome pakfile. To do this it adds a repack step that repacks
> the pakfiles that components_unittests needs into a
> components_unittests_resources.pak file, and then loads that pakfile
> explicitly.
>
> This change means that components_unittests now passes after a clean build,
> whereas before it would fail due to missing resources.
>
> This is based on blundell's change: https://codereview.chromium.org/258043003/
>
> BUG=348563, 450464
> R=blundell@chromium.org, thakis@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/045c9bf1d36f35643a077891dedf24054f2032a3
>
> Committed: https://chromium.googlesource.com/chromium/src/+/e98e8e7654b7e51f98e92514897f8e1284eaa571
TBR=blundell@chromium.org,thakis@chromium.org,maruel@chromium.org,jam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=348563, 450464
Committed: https://crrev.com/a2e3cc7a3586e7a27b414c47ae4db3d10efe40ba
Cr-Commit-Position: refs/heads/master@{#312490}
Patch Set 1 #
Created: 5 years, 11 months ago
(Patch set is too large to download)
Messages
Total messages: 7 (2 generated)
|