Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 867463005: Merge the background paint phase into the foreground phase. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
CC:
esprehn, abarth-chromium, jamesr, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Merge the background paint phase into the foreground phase. First step in getting rid of paint phases. Verified that deleting this phase entirely would cause flights-app-pixel.sky to fail and that it still passes in this patch, which just does the background painting as part of the foreground phase. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/efc3afd428bd85fd3d12e0dc941b5eb7248ca30b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -57 lines) Patch
M sky/engine/core/rendering/PaintPhase.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 4 chunks +5 lines, -12 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 3 chunks +2 lines, -8 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 3 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
5 years, 11 months ago (2015-01-26 05:19:25 UTC) #2
esprehn
lgtm
5 years, 11 months ago (2015-01-26 17:22:23 UTC) #3
ojan
5 years, 11 months ago (2015-01-26 23:52:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
efc3afd428bd85fd3d12e0dc941b5eb7248ca30b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698