Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 867403005: Enable Roboto by default for testing purpose. (Closed)

Created:
5 years, 10 months ago by xdai1
Modified:
5 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland this CL since the failed test problem cleared. Enable Roboto by default for testing purpose. The testing team wants to enable 'Roboto' by default and have real users to help report bugs too. In this CL 'Roboto' is enabled by default and can be disabled by going to chrome://flags and turn 'disable-roboto-font-ui' to on. Also modify the OobeWebUITest to make the tests run in full screen, otherwise the tests will fail due to the incorrect layout of supervised user creation UI (based on xiyuan@'s advice). Also modify the TextDoesntClip (based on asvitkine@'s advice). BUG=448948 Committed: https://crrev.com/d5f777b7342dfcfb64b8bdd635ec3599303be08a Cr-Commit-Position: refs/heads/master@{#313845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -18 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/chromeos/oobe_webui_browsertest.js View 2 chunks +13 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/font_helper_chromeos.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/base/font_helper_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
xdai1
Reland this CL since it was reverted because some test failed. Please re-lgtm. Thanks very ...
5 years, 10 months ago (2015-01-29 22:19:38 UTC) #2
Alexei Svitkine (slow)
LGTM for render_text_unittest.cc and histograms.xml
5 years, 10 months ago (2015-01-29 22:22:11 UTC) #3
sadrul
lgtm
5 years, 10 months ago (2015-01-29 23:39:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867403005/1
5 years, 10 months ago (2015-01-29 23:50:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 00:58:31 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 00:59:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5f777b7342dfcfb64b8bdd635ec3599303be08a
Cr-Commit-Position: refs/heads/master@{#313845}

Powered by Google App Engine
This is Rietveld 408576698