Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 867373003: Throw on range error when creating a string via API. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Throw on range error when creating a string via API. R=jkummerow@chromium.org BUG=v8:3853 LOG=Y Committed: https://crrev.com/8aae1b3096eb4e810231a7c23f6771d1f1a19400 Cr-Commit-Position: refs/heads/master@{#26574}

Patch Set 1 #

Total comments: 1

Patch Set 2 : update comment #

Patch Set 3 : add missing free #

Patch Set 4 : fix test #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -37 lines) Patch
M include/v8.h View 1 2 3 4 1 chunk +3 lines, -4 lines 0 comments Download
M src/api.cc View 1 2 3 4 1 chunk +7 lines, -5 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 1 chunk +33 lines, -0 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 1 2 3 2 chunks +31 lines, -28 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
Yang
5 years, 10 months ago (2015-02-10 15:58:08 UTC) #1
Jakob Kummerow
LGTM with nit. https://codereview.chromium.org/867373003/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/867373003/diff/1/src/api.cc#newcode5440 src/api.cc:5440: // We do not expect this ...
5 years, 10 months ago (2015-02-10 16:00:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867373003/20001
5 years, 10 months ago (2015-02-10 16:19:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/1292)
5 years, 10 months ago (2015-02-10 16:21:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867373003/20001
5 years, 10 months ago (2015-02-10 16:24:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/1294)
5 years, 10 months ago (2015-02-10 16:26:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867373003/40001
5 years, 10 months ago (2015-02-10 16:40:13 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/1296)
5 years, 10 months ago (2015-02-10 16:42:35 UTC) #15
Jakob Kummerow
lgtm
5 years, 10 months ago (2015-02-11 09:06:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867373003/60001
5 years, 10 months ago (2015-02-11 09:07:42 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/1098)
5 years, 10 months ago (2015-02-11 09:48:16 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867373003/80001
5 years, 10 months ago (2015-02-11 09:58:55 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-11 10:21:23 UTC) #24
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 10:21:34 UTC) #25
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/8aae1b3096eb4e810231a7c23f6771d1f1a19400
Cr-Commit-Position: refs/heads/master@{#26574}

Powered by Google App Engine
This is Rietveld 408576698