Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: util/file/file_io_win.cc

Issue 867363003: win: Implementation of CrashReportDatabase for Windows (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: fixes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: util/file/file_io_win.cc
diff --git a/util/file/file_io_win.cc b/util/file/file_io_win.cc
index adbe7a99efaa15498877220d67c38c40860f4170..64c10368746dc5e4c7f79a3c5b5b37ce92f84e85 100644
--- a/util/file/file_io_win.cc
+++ b/util/file/file_io_win.cc
@@ -102,8 +102,13 @@ FileHandle LoggingOpenFileForWrite(const base::FilePath& path,
disposition = CREATE_NEW;
break;
}
- HANDLE file = CreateFile(path.value().c_str(), GENERIC_WRITE, 0, nullptr,
- disposition, FILE_ATTRIBUTE_NORMAL, nullptr);
+ HANDLE file = CreateFile(path.value().c_str(),
+ GENERIC_READ | GENERIC_WRITE,
+ 0,
+ nullptr,
+ disposition,
+ FILE_ATTRIBUTE_NORMAL,
+ nullptr);
PLOG_IF(ERROR, file == INVALID_HANDLE_VALUE) << "CreateFile "
<< path.value().c_str();
return file;

Powered by Google App Engine
This is Rietveld 408576698