win: Implementation of CrashReportDatabase for Windows

util/test/scoped_temp_dir_win.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/test/scoped_temp_dir.h"
 
 #include <windows.h>
 
 #include "base/logging.h"
 #include "base/rand_util.h"
 #include "base/strings/string16.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "gtest/gtest.h"
 
 namespace crashpad {
 namespace test {
 
-// static
-base::FilePath ScopedTempDir::CreateTemporaryDirectory() {
+namespace {
+
+base::FilePath GenerateCandidateName() {
   wchar_t temp_path[MAX_PATH + 1];
   DWORD path_len = GetTempPath(MAX_PATH, temp_path);
   PCHECK(path_len != 0) << "GetTempPath";
   base::FilePath system_temp_dir(temp_path);
+  base::string16 new_dir_name = base::UTF8ToUTF16(base::StringPrintf(
+        "crashpad.test.%d.%I64x", GetCurrentProcessId(), base::RandUint64()));
+  return system_temp_dir.Append(new_dir_name);
+}
 
+}  // namespace
+
+void ScopedTempDir::Rename() {
   for (int count = 0; count < 50; ++count) {

[Mark Mentovai, 2015/02/11 17:25:50]

50 should be a constant local to this file, in the unnamed namespace above.

[scottmg, 2015/02/11 19:24:55]

Done.

-    // Try create a new temporary directory with random generated name. If the
-    // one we generate exists, keep trying another path name until we reach some
+    // Try to move to a new temporary directory with a randomly generated name.
+    // If the one we try exists, retry with a new name until we reach some
     // limit.
-    base::string16 new_dir_name = base::UTF8ToUTF16(base::StringPrintf(
-        "crashpad.test.%d.%I64x", GetCurrentProcessId(), base::RandUint64()));
+    base::FilePath target_path = GenerateCandidateName();
+    if (MoveFileEx(path_.value().c_str(), target_path.value().c_str(), 0)) {
+      path_ = target_path;
+      return;
+    }
+  }
 
-    base::FilePath path_to_create = system_temp_dir.Append(new_dir_name);
+  CHECK(false) << "Couldn't find temp dir name";
+}
+
+// static
+base::FilePath ScopedTempDir::CreateTemporaryDirectory() {
+  for (int count = 0; count < 50; ++count) {

[Mark Mentovai, 2015/02/11 17:25:50]

because you use it here too.

[scottmg, 2015/02/11 19:24:55]

Done.

+    // Try to create a new temporary directory with random generated name. If
+    // the one we generate exists, keep trying another path name until we reach
+    // some limit.
+    base::FilePath path_to_create = GenerateCandidateName();
     if (CreateDirectory(path_to_create.value().c_str(), NULL))
       return path_to_create;
   }
 
   CHECK(false) << "Couldn't find temp dir name";
   return base::FilePath();
 }
 
 // static
 void ScopedTempDir::RecursivelyDeleteTemporaryDirectory(
@@ skipping 25 matching lines @@
       break;
     }
   }
 
   EXPECT_TRUE(FindClose(search_handle));
   EXPECT_TRUE(RemoveDirectory(path.value().c_str()));
 }
 
 }  // namespace test
 }  // namespace crashpad