Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: Source/core/css/MediaQuerySetTest.cpp

Issue 867363002: Some invalid media queries are parsed as valid (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address review comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/parser/MediaQueryParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/MediaQuerySetTest.cpp
diff --git a/Source/core/css/MediaQuerySetTest.cpp b/Source/core/css/MediaQuerySetTest.cpp
index 85867e60df288a7c03f5dfb5e555270ce05a996b..6a0cb2acb39d3141b29d57eabcd5f540e05296bd 100644
--- a/Source/core/css/MediaQuerySetTest.cpp
+++ b/Source/core/css/MediaQuerySetTest.cpp
@@ -159,6 +159,16 @@ TEST(MediaQuerySetTest, Basic)
{"'\"\"\"', (max-width: 900px)", "not all, (max-width: 900px)", true},
{"\"'\"', (max-width: 900px)", "not all", true},
{"\"'''\", (max-width: 900px)", "not all, (max-width: 900px)", true},
+ {"not not", "not all", true},
+ {"not and", "not all", true},
+ {"not only", "not all", true},
+ {"not or", "not all", true},
+ {"only not", "not all", true},
+ {"only and", "not all", true},
+ {"only only", "not all", true},
+ {"only or", "not all", true},
+ {"not (orientation)", "not all", true},
+ {"only (orientation)", "not all", true},
{0, 0} // Do not remove the terminator line.
};
« no previous file with comments | « no previous file | Source/core/css/parser/MediaQueryParser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698