Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 867333002: Use enum string instead of value in code generator. (Closed)

Created:
5 years, 11 months ago by Zhenyao Mo
Modified:
5 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use enum string instead of value in code generator. BUG=450854, 429053 TEST=gpu_unittests R=piman@chromium.org Committed: https://crrev.com/1032a28748194c0587ef9d185b1553dbf64955c3 Cr-Commit-Position: refs/heads/master@{#312939}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +10 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 2 chunks +3 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Zhenyao Mo
piman: please take a look.
5 years, 11 months ago (2015-01-23 18:20:08 UTC) #2
piman
lgtm
5 years, 11 months ago (2015-01-23 21:15:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867333002/20001
5 years, 11 months ago (2015-01-23 21:55:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 11 months ago (2015-01-23 21:59:20 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 22:00:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1032a28748194c0587ef9d185b1553dbf64955c3
Cr-Commit-Position: refs/heads/master@{#312939}

Powered by Google App Engine
This is Rietveld 408576698