|
MacViews: Fix duplicate definition of ValidationMessageBubble::ShowAndCreate
Refactor into a virtual method on TabDialogs, with overrides for Views and
Cocoa.
ValidationMessageBubble is moved out of chrome namespace to be more
consistent with other dialogs.
BUG= 425229
Committed: https://crrev.com/49f9a7a9dc186798a76eac37e731e52b3a574af9
Cr-Commit-Position: refs/heads/master@{#313411}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+164 lines, -110 lines) |
Patch |
 |
M |
chrome/browser/ui/browser.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/browser.cc
|
View
|
|
1 chunk |
+3 lines, -9 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/tab_dialogs_cocoa.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
|
View
|
|
2 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/ui/cocoa/validation_message_bubble_cocoa.h
|
View
|
|
1 chunk |
+36 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm
|
View
|
|
4 chunks |
+20 lines, -39 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/tab_dialogs.h
|
View
|
|
3 chunks |
+12 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/validation_message_bubble.h
|
View
|
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/tab_dialogs_views.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/tab_dialogs_views.cc
|
View
|
|
2 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/ui/views/validation_message_bubble_view.h
|
View
|
|
1 chunk |
+40 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/validation_message_bubble_view.cc
|
View
|
|
1 chunk |
+23 lines, -56 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser_ui.gypi
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
Total messages: 9 (3 generated)
|