Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 867323005: MacViews: Fix duplicate definition of ValidationMessageBubble::ShowAndCreate (Closed)

Created:
5 years, 11 months ago by Andre
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@FirstResponder
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix duplicate definition of ValidationMessageBubble::ShowAndCreate Refactor into a virtual method on TabDialogs, with overrides for Views and Cocoa. ValidationMessageBubble is moved out of chrome namespace to be more consistent with other dialogs. BUG=425229 Committed: https://crrev.com/49f9a7a9dc186798a76eac37e731e52b3a574af9 Cr-Commit-Position: refs/heads/master@{#313411}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -110 lines) Patch
M chrome/browser/ui/browser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_dialogs_cocoa.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm View 2 chunks +9 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/validation_message_bubble_cocoa.h View 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm View 4 chunks +20 lines, -39 lines 0 comments Download
M chrome/browser/ui/tab_dialogs.h View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/validation_message_bubble.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tab_dialogs_views.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tab_dialogs_views.cc View 2 chunks +9 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/validation_message_bubble_view.h View 1 chunk +40 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/validation_message_bubble_view.cc View 1 chunk +23 lines, -56 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Andre
sky@ please review.
5 years, 11 months ago (2015-01-23 23:38:46 UTC) #2
Andre
Scott, ping?
5 years, 11 months ago (2015-01-27 23:05:46 UTC) #4
sky
LGTM
5 years, 11 months ago (2015-01-27 23:56:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867323005/20001
5 years, 11 months ago (2015-01-27 23:59:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 11 months ago (2015-01-28 00:03:54 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-28 00:05:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49f9a7a9dc186798a76eac37e731e52b3a574af9
Cr-Commit-Position: refs/heads/master@{#313411}

Powered by Google App Engine
This is Rietveld 408576698