Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 867323003: Added coverage support for all iOS targets. (Closed)

Created:
5 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
5 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added coverage support for all iOS targets. build/ios/coverage.gypi is conditionaly included into build/common.gypi for iOS platform. BUG=441961 Committed: https://crrev.com/f24d6e272a97eab52bc27322e07d4160ece83408 Cr-Commit-Position: refs/heads/master@{#312983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M build/ios/coverage.gypi View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Eugene But (OOO till 7-30)
5 years, 11 months ago (2015-01-23 19:31:36 UTC) #2
Nico
Every time you do something that spans more than 1 cl, please create a tracking ...
5 years, 11 months ago (2015-01-23 21:38:15 UTC) #3
Eugene But (OOO till 7-30)
On 2015/01/23 21:38:15, Nico wrote: > Every time you do something that spans more than ...
5 years, 11 months ago (2015-01-23 23:43:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867323003/1
5 years, 11 months ago (2015-01-23 23:44:57 UTC) #6
Nico
On 2015/01/23 23:43:13, eugenebut wrote: > On 2015/01/23 21:38:15, Nico wrote: > > Every time ...
5 years, 11 months ago (2015-01-23 23:59:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-24 00:47:27 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f24d6e272a97eab52bc27322e07d4160ece83408 Cr-Commit-Position: refs/heads/master@{#312983}
5 years, 11 months ago (2015-01-24 00:48:34 UTC) #9
Eugene But (OOO till 7-30)
5 years, 11 months ago (2015-01-24 00:52:43 UTC) #10
Message was sent while issue was closed.
On 2015/01/23 23:59:19, Nico wrote:
> On 2015/01/23 23:43:13, eugenebut wrote:
> > On 2015/01/23 21:38:15, Nico wrote:
> > > Every time you do something that spans more than 1 cl, please create a
> > tracking
> > > bug for that and reference it in all cls that are related to it (in this
> case,
> > > "coverage for chromium/ios", i suppose)
> > Updated the issue with our internal bug.
> > 
> > > Is this enough for me to repro the problems you were seeing with
chromium's
> > > clang?
> > I think the following steps should reproduce the problem:
> > 1.) Run: mkdir -p ~/.gyp && echo
> > '{"variables":{"enable_coverage":1,"clang_xcode":0,}}' > ~/.gyp/include.gypi
> &&
> > gclient runhooks
> > 2.) Compile ios_chrome_unittests target
> 
> Which command do I use to compile for the device? Which for the simulator?
> (Sorry for the newbie questions!)

Sorry, I don't build upstream code, but I believe the following commands should
work:
ninja -C out/Release-iphoneos All
ninja -C out/Release-iphonesimulator All

Powered by Google App Engine
This is Rietveld 408576698