Mac: Optimize toolbar/bookmark drawing during live resize

chrome/browser/ui/cocoa/background_gradient_view.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/background_gradient_view.h"
 
 #import "chrome/browser/themes/theme_properties.h"
 #import "chrome/browser/themes/theme_service.h"
 #import "chrome/browser/ui/cocoa/themed_window.h"
 #include "grit/theme_resources.h"
@@ skipping 103 matching lines @@
 - (void)viewDidMoveToWindow {
   [super viewDidMoveToWindow];
   if ([self window]) {
     // The new window for the view may have a different focus state than the
     // last window this view was part of. Force a re-draw to ensure that the
     // view draws the right state.
     [self windowDidChangeActive];
   }
 }
 
+- (void)viewWillStartLiveResize {
+  [super viewWillStartLiveResize];
+
+  ui::ThemeProvider* themeProvider = [[self window] themeProvider];
+  if (themeProvider && themeProvider->UsingSystemTheme()) {
+    // The default theme's background image is a subtle texture pattern that
+    // we can scale without being easily noticed. Optimize this case by
+    // skipping redraws during live resize.
+    [self setLayerContentsRedrawPolicy:
+              NSViewLayerContentsRedrawOnSetNeedsDisplay];

[Robert Sesek, 2015/02/04 16:13:49]

nit: over-indented

[Andre, 2015/02/04 16:46:26]

clang format wanted it that way, it's indenting from the start of the selector.
Do you prefer patch #3?

[Robert Sesek, 2015/02/04 16:54:56]

The most recent patch set is correct. I don't think what clang-format is doing
is actually style-guide approved.

+  }
+}
+
+- (void)viewDidEndLiveResize {
+  [super viewDidEndLiveResize];
+
+  if ([self layerContentsRedrawPolicy] !=
+      NSViewLayerContentsRedrawDuringViewResize) {
+    // If we have been scaling the layer during live resize, now is the time to
+    // redraw the layer.
+    [self
+        setLayerContentsRedrawPolicy:NSViewLayerContentsRedrawDuringViewResize];
+    [self setNeedsDisplay:YES];
+  }
+}
+
 - (void)setFrameOrigin:(NSPoint)origin {
   // The background color depends on the view's vertical position. This impacts
   // any child views that draw using this view's functions.
-  if (NSMinY([self frame]) != origin.y)
+  // When resizing the window, the view's vertical position (NSMinY) may change
+  // even though our relative position to the nearest window edge is still the
+  // same. Don't redraw unnecessarily in this case.
+  if (![self inLiveResize] && NSMinY([self frame]) != origin.y)
     [self cr_recursivelySetNeedsDisplay:YES];
 
   [super setFrameOrigin:origin];
 }
 
 // ThemedWindowDrawing implementation.
 
 - (void)windowDidChangeTheme {
   [self setNeedsDisplay:YES];
 }
 
 - (void)windowDidChangeActive {
   [self setNeedsDisplay:YES];
 }
 
 @end