Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 867273002: Change OK to NO_PARSER_ERROR in enum ParserError. (Closed)

Created:
5 years, 11 months ago by Bence
Modified:
5 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change OK to NO_PARSER_ERROR in enum ParserError. Change OK to NO_PARSER_ERROR in enum ParserError for convergence with server code. BUG=345769 Committed: https://crrev.com/f697c9cd8a17f1f3d760bc820f3c00c7be932b82 Cr-Commit-Position: refs/heads/master@{#313078}

Patch Set 1 #

Patch Set 2 : enum class #

Patch Set 3 : Add undef. #

Total comments: 2

Patch Set 4 : s/NO_ERROR/NO_PARSER_ERROR/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M net/spdy/spdy_headers_block_parser.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_headers_block_parser.cc View 1 2 3 5 chunks +10 lines, -11 lines 0 comments Download
M net/spdy/spdy_headers_block_parser_test.cc View 1 2 3 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Bence
Hey Ryan, I get compilation errors on Windows because of https://code.google.com/p/chromium/codesearch#chromium/src/net/tools/balsa/balsa_enums.h&q=no_error&sq=package:chromium&l=28. Can I please make ...
5 years, 11 months ago (2015-01-23 16:13:57 UTC) #2
Bence
On 2015/01/23 16:13:57, Bence wrote: > Hey Ryan, I get compilation errors on Windows because ...
5 years, 11 months ago (2015-01-23 19:12:51 UTC) #3
Bence
Ryan: PTAL.
5 years, 11 months ago (2015-01-23 20:24:25 UTC) #4
Ryan Hamilton
lgtm
5 years, 11 months ago (2015-01-26 03:50:49 UTC) #5
Ryan Hamilton
still lgtm, but fyi https://codereview.chromium.org/867273002/diff/40001/net/spdy/spdy_headers_block_parser.h File net/spdy/spdy_headers_block_parser.h (right): https://codereview.chromium.org/867273002/diff/40001/net/spdy/spdy_headers_block_parser.h#newcode69 net/spdy/spdy_headers_block_parser.h:69: NO_ERROR, Since this is a ...
5 years, 11 months ago (2015-01-26 03:51:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867273002/60001
5 years, 11 months ago (2015-01-26 15:49:38 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-26 16:31:04 UTC) #9
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/f697c9cd8a17f1f3d760bc820f3c00c7be932b82 Cr-Commit-Position: refs/heads/master@{#313078}
5 years, 11 months ago (2015-01-26 16:32:11 UTC) #10
Bence
5 years, 11 months ago (2015-01-26 16:48:21 UTC) #11
Message was sent while issue was closed. 
Great idea, landed with your proposed change.  (Will upstream soon.)  Thanks for
reviewing.

https://codereview.chromium.org/867273002/diff/40001/net/spdy/spdy_headers_bl...
File net/spdy/spdy_headers_block_parser.h (right):

https://codereview.chromium.org/867273002/diff/40001/net/spdy/spdy_headers_bl...
net/spdy/spdy_headers_block_parser.h:69: NO_ERROR,
On 2015/01/26 03:51:23, Ryan Hamilton wrote:
> Since this is a bit ugly, consider renaming this to be NO_PARSE_ERROR.

Done.

Powered by Google App Engine
This is Rietveld 408576698