tools/memory_inspector/memory_inspector/frontends/www_content/js/webservice.js - Issue 867263002: [memory-inspector] UI fixes + bump version number for release.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/memory_inspector/memory_inspector/frontends/www_content/js/webservice.js

Issue 867263002: [memory-inspector] UI fixes + bump version number for release. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/memory_inspector/memory_inspector/frontends/www_content/js/webservice.js

diff --git a/tools/memory_inspector/memory_inspector/frontends/www_content/js/webservice.js b/tools/memory_inspector/memory_inspector/frontends/www_content/js/webservice.js

index 1a62a6d62d399e207ab20a2476c9dce3c8c5367f..5f4b8f2ab4f24b7b47ad6408f256574a18dd522b 100644

--- a/tools/memory_inspector/memory_inspector/frontends/www_content/js/webservice.js

+++ b/tools/memory_inspector/memory_inspector/frontends/www_content/js/webservice.js

@@ -23,7 +23,8 @@ this.ajaxRequest = function(path, responseCallback, errorCallback, postArgs) {

console.log('AJAX error (req: ' + path + ').');

console.log('HTTP response: ' + xhr.status + ' ' + thrownError);

console.log(xhr.responseText);

- rootUi.showDialog(xhr.responseText || 'Unknown server error');

+ rootUi.showDialog((xhr.responseText || 'Unknown server error.') +

+ ' Check the console for more details.');

if (errorCallback)

errorCallback(xhr.status, xhr.responseText);

if (xhr.readyState < 4 && this_.onServerUnreachableOrTimeout != null)

« no previous file with comments | « tools/memory_inspector/memory_inspector/frontends/www_content/js/processes.js ('k') | no next file » | no next file with comments »