Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Issue 867243005: X87: Externalize deoptimization reasons. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Externalize deoptimization reasons. port 2491a639bf46da4bfdcf65329305ee3053aa5fec (r26463) original commit message: Externalize deoptimization reasons. 1) The hardcoded strings were converted into DeoptReason enum. 2) Deopt comment were converted into a pair location and deopt reason entries so the deopt reason tracking mode would less affect the size of the RelocInfo table and heap. 3) DeoptReason entry in RelocInfo reuses kCommentTag value and generates short entry in RelocInfo table. BUG= Committed: https://crrev.com/ebb77c37ed78964470e41ea6a0886dd720b7ac98 Cr-Commit-Position: refs/heads/master@{#26526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M src/x87/assembler-x87.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x87/lithium-codegen-x87.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 10 months ago (2015-02-09 11:13:32 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-09 12:33:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867243005/1
5 years, 10 months ago (2015-02-09 12:33:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 14:10:11 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 14:10:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebb77c37ed78964470e41ea6a0886dd720b7ac98
Cr-Commit-Position: refs/heads/master@{#26526}

Powered by Google App Engine
This is Rietveld 408576698