Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: pkg/compiler/lib/src/elements/modelx.dart

Issue 867233004: Support constructor declarations in analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/elements/elements.dart ('k') | pkg/compiler/lib/src/resolution/signatures.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/elements/modelx.dart
diff --git a/pkg/compiler/lib/src/elements/modelx.dart b/pkg/compiler/lib/src/elements/modelx.dart
index 0531a73146c188b08eaa188d423d28b1fa93db1f..a292f037403b4e2a0145550b6ed69c9925895e38 100644
--- a/pkg/compiler/lib/src/elements/modelx.dart
+++ b/pkg/compiler/lib/src/elements/modelx.dart
@@ -299,6 +299,7 @@ class ErroneousElementX extends ElementX implements ErroneousElement {
get type => unsupported();
get cachedNode => unsupported();
get functionSignature => unsupported();
+ get parameters => unsupported();
get patch => null;
get origin => this;
get immediateRedirectionTarget => unsupported();
@@ -1532,12 +1533,16 @@ class FormalElementX extends ElementX
abstract class ParameterElementX extends FormalElementX
with PatchMixin<ParameterElement> implements ParameterElement {
final Expression initializer;
+ final bool isOptional;
+ final bool isNamed;
ParameterElementX(ElementKind elementKind,
FunctionElement functionDeclaration,
VariableDefinitions definitions,
Identifier identifier,
- this.initializer)
+ this.initializer,
+ {this.isOptional: false,
+ this.isNamed: false})
: super(elementKind, functionDeclaration, definitions, identifier);
FunctionElement get functionDeclaration => enclosingElement;
@@ -1553,12 +1558,17 @@ abstract class ParameterElementX extends FormalElementX
class LocalParameterElementX extends ParameterElementX
implements LocalParameterElement {
+
+
LocalParameterElementX(FunctionElement functionDeclaration,
VariableDefinitions definitions,
Identifier identifier,
- Expression initializer)
+ Expression initializer,
+ {bool isOptional: false,
+ bool isNamed: false})
: super(ElementKind.PARAMETER, functionDeclaration,
- definitions, identifier, initializer);
+ definitions, identifier, initializer,
+ isOptional: isOptional, isNamed: isNamed);
}
/// Parameters in constructors that directly initialize fields. For example:
@@ -1571,9 +1581,12 @@ class InitializingFormalElementX extends ParameterElementX
VariableDefinitions variables,
Identifier identifier,
Expression initializer,
- this.fieldElement)
+ this.fieldElement,
+ {bool isOptional: false,
+ bool isNamed: false})
: super(ElementKind.INITIALIZING_FORMAL, constructorDeclaration,
- variables, identifier, initializer);
+ variables, identifier, initializer,
+ isOptional: isOptional, isNamed: isNamed);
accept(ElementVisitor visitor) => visitor.visitFieldParameterElement(this);
@@ -1806,6 +1819,14 @@ abstract class BaseFunctionElementX
return functionSignatureCache;
}
+ List<ParameterElement> get parameters {
+ // TODO(johnniwinther): Store the list directly, possibly by using List
+ // instead of Link in FunctionSignature.
+ List<ParameterElement> list = <ParameterElement>[];
+ functionSignature.forEachParameter((e) => list.add(e));
+ return list;
+ }
+
FunctionType computeType(Compiler compiler) {
if (typeCache != null) return typeCache;
typeCache = computeSignature(compiler).type;
« no previous file with comments | « pkg/compiler/lib/src/elements/elements.dart ('k') | pkg/compiler/lib/src/resolution/signatures.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698