pkg/compiler/lib/src/dart_backend/placeholder_collector.dart - Issue 867233004: Support constructor declarations in analyzer2dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/dart_backend/placeholder_collector.dart

Issue 867233004: Support constructor declarations in analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/dart_backend/outputter.dart ('K') | « pkg/compiler/lib/src/dart_backend/outputter.dart ('k') | pkg/compiler/lib/src/elements/elements.dart » ('j') | pkg/compiler/lib/src/elements/modelx.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/dart_backend/placeholder_collector.dart

diff --git a/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart b/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart

index 694b62379db603a5b0c8af8c90592fb6a26579ea..9f9a2b858b4988dbe588635f28f5eab9c55f5f2a 100644

--- a/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart

+++ b/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart

@@ -189,7 +189,6 @@ class PlaceholderCollector extends Visitor {

FunctionElement element, FunctionExpression node) {

if (element.isConstructor) {

ConstructorElement constructor = element;

- DartType type = element.enclosingClass.thisType.asRaw();

tryMakeConstructorPlaceholder(node.name, element);

RedirectingFactoryBody bodyAsRedirectingFactoryBody =

node.body.asRedirectingFactoryBody();

@@ -197,7 +196,6 @@ class PlaceholderCollector extends Visitor {

// Factory redirection.

FunctionElement redirectTarget = constructor.immediateRedirectionTarget;

assert(redirectTarget != null && redirectTarget != element);

- type = redirectTarget.enclosingClass.thisType.asRaw();

tryMakeConstructorPlaceholder(

bodyAsRedirectingFactoryBody.constructorReference,

redirectTarget);