pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart - Issue 867233004: Support constructor declarations in analyzer2dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

Issue 867233004: Support constructor declarations in analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analyzer2dart/lib/src/modely.dart ('K') | « pkg/analyzer2dart/test/sexpr_test.dart ('k') | pkg/compiler/lib/src/dart_backend/outputter.dart » ('j') | pkg/compiler/lib/src/dart_backend/outputter.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

diff --git a/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart b/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

index e16192237cd66a55d055e4d620fdbef12e2bbb4d..e9b99b005687dbe15d8c3e925adbb18c1905942a 100644

--- a/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

+++ b/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

@@ -480,9 +480,9 @@ class ParentVisitor extends RecursiveVisitor {

processConstructorDefinition(ConstructorDefinition node) {

node.body.parent = node;

int index = 0;

- node.parameters.forEach((Parameter parameter) {

+ node.parameters.forEach((Definition parameter) {

parameter.parent = node;

- parameter.parent_index = index++;

+ if (parameter is Parameter) parameter.parent_index = index++;

Johnni Winther 2015/01/28 13:38:02 Fixes a checked mode bug for the new dart2dart bac

herhut 2015/01/28 14:12:50 This still reads strange...

Johnni Winther 2015/01/29 07:51:07 Yes. But now its is valid, and all consistent with

});

node.initializers.forEach((Initializer i) => i.parent = node);

}