Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 867183006: Revert of Allow new zoom bubble to override current one. (Closed)

Created:
5 years, 10 months ago by wjmaclean
Modified:
5 years, 10 months ago
CC:
chromium-reviews, fsamuel, raymes
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow new zoom bubble to override current one. (patchset #6 id:100001 of https://codereview.chromium.org/849693006/) Reason for revert: The changes in this CL are causing a crash: crbug.com/453564 Original issue's description: > Allow new zoom bubble to override current one. > > At present, if a user changes zoom on OSX while the zoom bubble is > already being shown, the new zoom bubble (with the most up to date > information) is not shown. This CL changes this behaviour by allowing > a new zoom bubble to be created, and replace the existing one. > > Example: load a PDF and repeatedly click the zoom +/- controls in the > lower-right corner of the viewer. > > BUG=444995 > > Committed: https://crrev.com/a95ea7031e472fd5d0968955989c963381dfaf5f > Cr-Commit-Position: refs/heads/master@{#313564} TBR=rohitrao@chromium.org,erikchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=444995 Committed: https://crrev.com/97b62a99d561261001b8e4ddd2a5946a6fa743bb Cr-Commit-Position: refs/heads/master@{#313785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M chrome/browser/ui/cocoa/browser/zoom_bubble_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm View 4 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wjmaclean
Created Revert of Allow new zoom bubble to override current one.
5 years, 10 months ago (2015-01-29 20:55:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867183006/1
5 years, 10 months ago (2015-01-29 20:56:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 20:57:18 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 20:59:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97b62a99d561261001b8e4ddd2a5946a6fa743bb
Cr-Commit-Position: refs/heads/master@{#313785}

Powered by Google App Engine
This is Rietveld 408576698