Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: test/test_utils.dart

Issue 867133002: pkg/matcher: refactor with unittest v0.12 work (Closed) Base URL: https://github.com/dart-lang/matcher.git@master
Patch Set: cl nits Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/test_common.dart ('k') | test/throws_matchers_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/test_utils.dart
diff --git a/test/test_utils.dart b/test/test_utils.dart
index 4df8e2ef6c742b79c37adc1972af3c1f11c90447..fb342a49a79477deb0a983b02428c58d646d4ecc 100644
--- a/test/test_utils.dart
+++ b/test/test_utils.dart
@@ -4,36 +4,17 @@
library matcher.test_utils;
-import 'dart:async';
+import 'package:unittest/unittest.dart';
-import 'package:matcher/matcher.dart';
-import 'package:unittest/unittest.dart' show test, expectAsync;
+void shouldFail(value, Matcher matcher, expected) {
+ var failed = false;
+ try {
+ expect(value, matcher);
+ } on TestFailure catch (err) {
+ failed = true;
-int _errorCount;
-String _errorString;
-FailureHandler _testHandler = null;
+ var _errorString = err.message;
-class MyFailureHandler extends DefaultFailureHandler {
- void fail(String reason) {
- ++_errorCount;
- _errorString = reason;
- }
-}
-
-void initUtils() {
- if (_testHandler == null) {
- _testHandler = new MyFailureHandler();
- }
-}
-
-void shouldFail(value, Matcher matcher, expected, {bool isAsync: false}) {
- configureExpectFailureHandler(_testHandler);
- _errorCount = 0;
- _errorString = '';
- expect(value, matcher);
- afterTest() {
- configureExpectFailureHandler(null);
- expect(_errorCount, equals(1));
if (expected is String) {
expect(_errorString, equalsIgnoringWhitespace(expected));
} else {
@@ -41,44 +22,14 @@ void shouldFail(value, Matcher matcher, expected, {bool isAsync: false}) {
}
}
- if (isAsync) {
- Timer.run(expectAsync(afterTest));
- } else {
- afterTest();
- }
+ expect(failed, isTrue, reason: 'Expected to fail.');
}
-void shouldPass(value, Matcher matcher, {bool isAsync: false}) {
- configureExpectFailureHandler(_testHandler);
- _errorCount = 0;
- _errorString = '';
+void shouldPass(value, Matcher matcher) {
expect(value, matcher);
- afterTest() {
- configureExpectFailureHandler(null);
- expect(_errorCount, equals(0));
- }
- if (isAsync) {
- Timer.run(expectAsync(afterTest));
- } else {
- afterTest();
- }
}
doesNotThrow() {}
doesThrow() {
throw 'X';
}
-
-class PrefixMatcher extends Matcher {
- final String _prefix;
- const PrefixMatcher(this._prefix);
- bool matches(item, Map matchState) {
- return item is String &&
- (collapseWhitespace(item)).startsWith(collapseWhitespace(_prefix));
- }
-
- Description describe(Description description) => description
- .add('a string starting with ')
- .addDescriptionOf(collapseWhitespace(_prefix))
- .add(' ignoring whitespace');
-}
« no previous file with comments | « test/test_common.dart ('k') | test/throws_matchers_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698