Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 867123007: Fix more tests in the import history. (Closed)

Created:
5 years, 11 months ago by mtomasz
Modified:
5 years, 11 months ago
Reviewers:
Steve McKay
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix more tests in the import history. Promises were not chained properly. As a result, the majority of tests were always passing despite of errors. TEST=browser_tests: *ImportHistoryTest* BUG=None Committed: https://crrev.com/cb481279b165f1b2155276a48c698dc5df980df3 Cr-Commit-Position: refs/heads/master@{#312972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M ui/file_manager/file_manager/background/js/import_history_unittest.js View 10 chunks +18 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@smckay: PTAL.
5 years, 11 months ago (2015-01-23 23:01:39 UTC) #2
Steve McKay
lgtm
5 years, 11 months ago (2015-01-23 23:04:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867123007/1
5 years, 11 months ago (2015-01-23 23:06:19 UTC) #5
mtomasz
On 2015/01/23 23:04:33, Steve McKay wrote: > lgtm Other test files look OK.
5 years, 11 months ago (2015-01-23 23:07:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-24 00:00:01 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 00:01:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb481279b165f1b2155276a48c698dc5df980df3
Cr-Commit-Position: refs/heads/master@{#312972}

Powered by Google App Engine
This is Rietveld 408576698